Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streaming): unstable lifetime compiling bug in join state #2704

Merged
merged 1 commit into from
May 20, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.com

What's changed and what's your intention?

Sometimes the compiler will complain about the lifetime for these functions while sometimes it will accept. 🤣 Just add a more explicit lifetime annotation for them.

image

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao requested review from skyzh and yuhao-su May 20, 2022 08:44
@github-actions github-actions bot added the type/fix Bug fix label May 20, 2022
@lmatz
Copy link
Contributor

lmatz commented May 20, 2022

LMAO, IIRC, I am the one who removed this explicit lifetime because Clippy complains.

Maybe not the same place, but quite similar.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2704 (5480e80) into main (6687303) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
- Coverage   72.42%   72.42%   -0.01%     
==========================================
  Files         685      685              
  Lines       89266    89266              
==========================================
- Hits        64651    64649       -2     
- Misses      24615    24617       +2     
Flag Coverage Δ
rust 72.42% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/managed_state/join/mod.rs 73.09% <75.00%> (ø)
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/storage/src/object/disk.rs 95.52% <0.00%> (-0.27%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yuhao-su
Copy link
Contributor

cargo clean & cargo build will fix.
Don't know why...

@BugenZhao
Copy link
Member Author

cargo clean & cargo build will fix.
Don't know why...

It might still fail on the next builds...

@BugenZhao BugenZhao enabled auto-merge (squash) May 20, 2022 09:02
@BugenZhao BugenZhao disabled auto-merge May 20, 2022 09:02
@BugenZhao BugenZhao enabled auto-merge (squash) May 20, 2022 09:02
@BugenZhao BugenZhao merged commit 78c257b into main May 20, 2022
@BugenZhao BugenZhao deleted the bz/fix-compile-hash-join branch May 20, 2022 09:16
@BugenZhao
Copy link
Member Author

Might related: rust-lang/rust#96645

@StrikeW
Copy link
Contributor

StrikeW commented May 20, 2022

encountered the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants