fixes issue #4 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stvad
reviewed
Jan 30, 2020
webpack.config.js
Outdated
| new webpack.DefinePlugin({ | ||
| 'NODE_ENV': JSON.stringify(nodeEnv), | ||
| 'WEB_BROWSER': JSON.stringify(webBrowser), | ||
| }), | ||
| extensionReloader, | ||
| new CleanWebpackPlugin(), | ||
| new CleanWebpackPlugin({ | ||
| // cleanStaleWebpackAssets: false, // another way to resolve conflict with `CopyWebpackPlugin` |
There was a problem hiding this comment.
just to check - do we need both of those ( based on "another way" phrasing)?
There was a problem hiding this comment.
Just copyUnmodified should be enough.
Both options were suggested on the thread I linked to, and they both worked for me, but I think copyUnmodified is the better solution.
I left both there just in case. Maybe merge into another branch to test it then remove the commented one?
There was a problem hiding this comment.
I see. I'd prefer to go with just one of them if that's enough. Would appreciate if you can do the test you mention :). Otherwise - I'll take a look at it tonight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4