Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue #4 #5

Merged
merged 2 commits into from
Jan 31, 2020
Merged

fixes issue #4 #5

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab0ad2
fixes issue #4
dalmo3 Jan 30, 2020
7d37729
removed unused hack
dalmo3 Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fixes issue #4
  • Loading branch information
@dalmo3
dalmo3 committed Jan 30, 2020
commit fab0ad2da4be2a83a1f66c0035e44bc63a954c97
8 changes: 6 additions & 2 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,16 @@ module.exports = {
to: path.join(distRootPath, 'manifest.json'),
toType: 'file',
}
]),
],{
copyUnmodified: true // resolve conflict with `CleanWebpackPlugin`
}),
new webpack.DefinePlugin({
'NODE_ENV': JSON.stringify(nodeEnv),
'WEB_BROWSER': JSON.stringify(webBrowser),
}),
extensionReloader,
new CleanWebpackPlugin(),
new CleanWebpackPlugin({
// cleanStaleWebpackAssets: false, // another way to resolve conflict with `CopyWebpackPlugin`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to check - do we need both of those ( based on "another way" phrasing)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copyUnmodified should be enough.

Both options were suggested on the thread I linked to, and they both worked for me, but I think copyUnmodified is the better solution.

I left both there just in case. Maybe merge into another branch to test it then remove the commented one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I'd prefer to go with just one of them if that's enough. Would appreciate if you can do the test you mention :). Otherwise - I'll take a look at it tonight

}),
],
}