Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mouseover event for page titles to show day name #82

Merged
merged 10 commits into from
Jun 17, 2020

Conversation

braydie
Copy link
Contributor

@braydie braydie commented Jun 16, 2020

Introduces a mouseover event that will parse page refs and titles for date and insert the day name as the title to that element

image
image

Copy link
Member

@Stvad Stvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing! Added a few comments most are minor - biggest thing is adding a setting for this :) Looking forward to merging it!

src/ts/contentScripts/entry/index.ts Outdated Show resolved Hide resolved
src/ts/core/features/day-title.ts Outdated Show resolved Hide resolved
src/ts/core/features/day-title.ts Show resolved Hide resolved
src/ts/core/features/day-title.ts Outdated Show resolved Hide resolved
src/ts/core/features/day-title.ts Outdated Show resolved Hide resolved
@Stvad Stvad merged commit d74c04c into roam-unofficial:master Jun 17, 2020
@Stvad
Copy link
Member

Stvad commented Jun 17, 2020

Looks good to me now! Thank you again!

@Stvad
Copy link
Member

Stvad commented Jun 18, 2020

initiated publishing to the Chrome store - that takes a bit https://chrome.google.com/webstore/detail/ebckolanhdjilblnkcgcgifaikppnhba/publish-delayed?authuser=2&hl=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants