Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mouseover event for page titles to show day name #82

Merged
merged 10 commits into from
Jun 17, 2020
Merged

Added mouseover event for page titles to show day name #82

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
62540ab
Added mouseover event for page titles to show day name
braydie Jun 16, 2020
0640d61
Added function for getting a day name from a date
braydie Jun 17, 2020
bad1878
Moved declaration of `day` closer to first usage
braydie Jun 17, 2020
c01fd20
Updated function to use ?. operator
braydie Jun 17, 2020
ba56c01
Updated getDayFromDate function to use new RoamDate function for gett…
braydie Jun 17, 2020
e2c3c97
Turned day title into proper feature
braydie Jun 17, 2020
6fe5c21
Added day title to features
braydie Jun 17, 2020
3f4ad39
Removed date title from content scripts entry point
braydie Jun 17, 2020
097a7c3
Added another selector to also target page titles
braydie Jun 17, 2020
1123884
moved getDayName into common date file
braydie Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated function to use ?. operator
  • Loading branch information
@braydie
braydie committed Jun 17, 2020
commit c01fd20bc5559b251ce453fd1a3cb56f0e1914b9
9 changes: 2 additions & 7 deletions src/ts/core/features/day-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,8 @@ function getDayFromDate(name: string) {
return null
}

function isPageViewTitle(element: HTMLElement) {
return (
element.parentNode &&
element.parentNode.parentNode &&
(element.parentNode.parentNode as Element).classList.contains('rm-ref-page-view-title')
)
}
const isElementPageViewTitle = (element: HTMLElement) =>
(element.parentNode?.parentNode as HTMLElement)?.classList?.contains('rm-ref-page-view-title')

document.querySelector('body')?.addEventListener('mouseover', ev => {
const target = ev.target as HTMLElement
Expand Down