21529 #7
Merged
21529 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getter had a pre-condition of calling Resolve, and was only ever called once immediate after the Resolve. The extra API burden (and spurious copy of the return value) is not useful.
When template types are known, nontrivial code must live in cc file.
The parser only ever needs to know about instanced names. Converting back and forth with strings just makes the code impossible to reason about which strings are valid under what conditions and relative to where. The name-punning confusion is still there, at least now is fully encapsulated within the filter group resolver cc file.
|
FYI This might be easier to understand if you set "Review each commit separately" in the review. I don't have permissions to change that setting when I open the page. |
rpoyner-tri
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 2 of 3 files at r2, 10 of 10 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)
rpoyner-tri
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is