Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21529 #7

Merged
merged 3 commits into from
Jun 18, 2024
Merged

21529 #7

merged 3 commits into from
Jun 18, 2024

Commits on Jun 18, 2024

  1. Remove overly-circuitous return value 

    The getter had a pre-condition of calling Resolve, and was only ever
called once immediate after the Resolve. The extra API burden (and
spurious copy of the return value) is not useful.
    @jwnimmer-tri
    jwnimmer-tri committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    332350a View commit details
    Browse the repository at this point in the history

  2. Fix per GSG inline functions rule 

    When template types are known, nontrivial code must live in cc file.
    @jwnimmer-tri
    jwnimmer-tri committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    119194f View commit details
    Browse the repository at this point in the history

  3. Switch Parser<=>Resolver interface to InstancedName, not strings 

    The parser only ever needs to know about instanced names. Converting
back and forth with strings just makes the code impossible to reason
about which strings are valid under what conditions and relative to
where.

The name-punning confusion is still there, at least now is fully
encapsulated within the filter group resolver cc file.
    @jwnimmer-tri
    jwnimmer-tri committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0e7c503 View commit details
    Browse the repository at this point in the history