Integrate Launchable into mingw #11043
Merged
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
changed the title
ono-max
force-pushed
the
support-mingw
branch
3 times, most recently
from
55dea43
to
3dc17ae
Compare
ono-max
changed the title
ono-max
commented
Jun 24, 2024
| @@ -88,8 +88,7 @@ runs: | |||
| working-directory: ${{ inputs.srcdir }} | |||
| run: | | |||
| set -x | |||
| PATH=$PATH:$(python -msite --user-base)/bin | |||
| echo "PATH=$PATH" >> $GITHUB_ENV | |||
| echo "$(python -msite --user-base)/bin" >> $GITHUB_PATH | |||
There was a problem hiding this comment.
To prevent this step from replacing all backslashes with forward slashes, $GITHUB_PATH is used. Based on my investigation, it seems to be that all paths are expressed as Unix path style when referring them in Bash.
https://github.com/ruby/ruby/actions/runs/9626581444/job/26576319914?pr=11043#step:10:271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Launchable has been used for analyzing flaky tests. Kokubun-san asked me to integrate Launchable into mingw for analyzing flay tests in mingw, so I've created this PR to address it.
Examples for using Launchable:
#11025
#10749