Remove error code check in doc test

[GuillaumeGomez]

Needed by rust-lang/rust#53933

cc @alexcrichton

[rust-highfive]

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

@bors: r+

[bors]

📌 Commit de3c4cb5dba53ce28b31194e76237147475a230a has been approved by alexcrichton

[bors]

⌛ Testing commit de3c4cb5dba53ce28b31194e76237147475a230a with merge 0aca6437ee5b61cf27c2056dc0bf047d1dd945e4...

[ehuss]

This isn't going to pass because the test harness asserts that cargo returns 0 by default. There currently isn't a way to ignore the return code, though that can be easily added.

[GuillaumeGomez]

Is it a check performed in cargo or in rustc? (if in rustc, I'll send the PR there which will give a nice cascade of PRs haha).

[ehuss]

The check is in the testsuite code. The default is set here. I think it would be reasonable to add another method next to with_status that sets expect_exit_code to None.

[GuillaumeGomez]

Agreed. Adding it to this PR as well.

[dwijnand]

Maybe we can revert the test changes in b1d6a7e then ;-)

Edit: I mean in the future. Not (necessarily) in this PR.

[GuillaumeGomez]

Euh... Ok! New commit incoming!

[GuillaumeGomez]

@dwijnand: Done as well. Anything else? 😆

[dwijnand]

Thank you! 🙇 Sorry for the misunderstanding.

[GuillaumeGomez]

Cool! Then let's hope it'll pass tests now. :)

[alexcrichton]

@bors: r+

[bors]

📌 Commit 2fc6b3e has been approved by alexcrichton

[bors]

⌛ Testing commit 2fc6b3e with merge 509bf99...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 509bf99 to master...