Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future proof an unstable test #6176

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Future proof an unstable test #6176

merged 2 commits into from
Oct 16, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 15, 2018

statics (even extern ones) will get their type checked for a Sized bound in order to fix rust-lang/rust#54410

statics (even extern ones) will get their type checked for a `Sized` bound in order to fix rust-lang/rust#54410
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Looks good to me! I think there's some CI errors though?

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Oct 16, 2018

📌 Commit 81a7f47 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Oct 16, 2018

⌛ Testing commit 81a7f47 with merge 09ce4b5...

bors added a commit that referenced this pull request Oct 16, 2018
Future proof an unstable test

statics (even extern ones) will get their type checked for a `Sized` bound in order to fix rust-lang/rust#54410
@bors
Copy link
Collaborator

bors commented Oct 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 09ce4b5 to master...

@bors bors merged commit 81a7f47 into rust-lang:master Oct 16, 2018
@oli-obk oli-obk deleted the patch-1 branch October 16, 2018 14:59
bors added a commit that referenced this pull request Oct 24, 2018
[BETA] Partially destabilize edition.

Removes edition from `cargo new`, and documentation.

Also includes (parts of) #6176 and #6027 to get the beta branch to pass tests on CI.
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE (stable segfault) in LLVM with creative FFI types
5 participants