Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm32-unknown targets #1115

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Add wasm32-unknown targets #1115

merged 1 commit into from
Jun 30, 2024

Conversation

Kuuuube
Copy link
Contributor

@Kuuuube Kuuuube commented Jun 30, 2024

Mucked around with this and this seems to fix #1113 along with the changes made in #1114

Targeting the pr branch of #1114 so this can be pulled into that pr

@Kuuuube Kuuuube mentioned this pull request Jun 30, 2024
Merged
NobodyXu
NobodyXu approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NobodyXu NobodyXu merged commit 92d5c66 into rust-lang:fix-wasi Jun 30, 2024
24 checks passed
NobodyXu
NobodyXu reviewed Jun 30, 2024
View reviewed changes
src/lib.rs
"wasm32-wasi",
"wasm32-wasip1",
"wasm32-wasip1-threads",
"wasm32-wasip2",
"wasm32-wasi-threads",
"wasm32-unknown-wasi",
"wasm32-unknown-unknown",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the additional of wasm32-unknown-unknown, I feel like I should rename this to is_wasm_target instead, but then this list here also doesn't cover all wasm targets.

NobodyXu added a commit that referenced this pull request Jun 30, 2024
@NobodyXu @Kuuuube
Fix compilation for wasm: env WASI_SYSROOT should be optional (#1114)
fe9ccd1 
* Fix compilation for wasm: env WASI_SYSROOT should be optional

On ubuntu-latest github action runner, it used to work without the environment variable.

Fixed #1109 #1113

* Add wasm32-unknown targets (#1115)

---------

Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
@antaalt antaalt mentioned this pull request Jun 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kuuuube @NobodyXu