Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm32-unknown targets #1115

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Add wasm32-unknown targets #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add wasm32-unknown targets
  • Loading branch information
@Kuuuube
Kuuuube committed Jun 30, 2024
commit 2bcbbc0af5ff9399d20fce9b8fe6a6642b844a6b
4 changes: 3 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3942,12 +3942,14 @@ impl Build {
}
}
fn is_wasi_target(target: &str) -> bool {
const TARGETS: [&'static str; 5] = [
const TARGETS: [&'static str; 7] = [
"wasm32-wasi",
"wasm32-wasip1",
"wasm32-wasip1-threads",
"wasm32-wasip2",
"wasm32-wasi-threads",
"wasm32-unknown-wasi",
"wasm32-unknown-unknown",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the additional of wasm32-unknown-unknown, I feel like I should rename this to is_wasm_target instead, but then this list here also doesn't cover all wasm targets.

];
return TARGETS.contains(&target);
}
Expand Down