This repository has been archived by the owner on Feb 5, 2019. It is now read-only.
Backport fix for encoding_rs performance regression #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit rL308422 introduces a restriction for folding unconditional branches. Specifically if empty block with unconditional branch leads to header of the loop then elimination of this basic block is prohibited. However it seems this condition is redundantly strict. If elimination of this basic block does not introduce more back edges then we can eliminate this block. The patch implements this relax of restriction. The test profile/Linux/counter_promo_nest.c in compiler-rt project is updated to meet this change. Reviewers: efriedma, mcrosier, pacxx, hsung, davidxl Reviewed By: pacxx Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D42691 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@324572 91177308-0d34-0410-b5e6-96231b3b80d8
|
Looks good, thanks! |
nox
added a commit
to nox/rust
that referenced
this pull request
May 18, 2018
This brings in rust-lang/llvm#115, which fixes rust-lang#49873.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 19, 2018
Update LLVM to 56c931901cfb85cd6f7ed44c7d7520a8de1edf97 This brings in rust-lang/llvm#115, which fixes rust-lang#49873.
bors
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jun 1, 2018
This brings in rust-lang/llvm#115, which fixes #49873.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports llvm-mirror/llvm@4c64dfe, which fixes the performance regression reported in rust-lang/rust#49873.