Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM to 56c931901cfb85cd6f7ed44c7d7520a8de1edf97 #50827

Merged
merged 1 commit into from
May 20, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented May 17, 2018

This brings in rust-lang/llvm#115, which fixes #49873.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2018
@eddyb
Copy link
Member

eddyb commented May 17, 2018

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2018

📌 Commit 87ce3ae has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2018
@kennytm
Copy link
Member

kennytm commented May 17, 2018

BTW, this PR also brought in rust-lang/llvm#116 to fix #50754.

@michaelwoerister
Copy link
Member

cc @hsivonen

@oli-obk
Copy link
Contributor

oli-obk commented May 18, 2018

@bors r=eddyb

@bors
Copy link
Contributor

bors commented May 18, 2018

📌 Commit 032831d has been approved by eddyb

@nikomatsakis nikomatsakis assigned eddyb and unassigned nikomatsakis May 18, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 19, 2018
Update LLVM to 56c931901cfb85cd6f7ed44c7d7520a8de1edf97

This brings in rust-lang/llvm#115, which fixes rust-lang#49873.
bors added a commit that referenced this pull request May 19, 2018
Rollup of 8 pull requests

Successful merges:

 - #50531 (Cleanup uses of TypeIdHasher and replace them with StableHasher)
 - #50819 (Fix potential divide by zero)
 - #50827 (Update LLVM to 56c931901cfb85cd6f7ed44c7d7520a8de1edf97)
 - #50829 (CheckLoopVisitor: also visit break expressions)
 - #50854 (in which the unused shorthand field pattern debacle/saga continues)
 - #50858 (Reorder description for snippets in rustdoc documentation)
 - #50883 (Fix warning when building stage0 libcore)
 - #50889 (Update clippy)

Failed merges:
@bors bors merged commit 032831d into rust-lang:master May 20, 2018
@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 21, 2018
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 24, 2018
bors added a commit that referenced this pull request Jun 1, 2018
[beta] Process backports

Merged and approved:

* #50812: Fix issue #50811 (`NaN > NaN` was true).
* #50827: Update LLVM to `56c931901cfb85cd6f7ed44c7d7520a8de1edf97`
* #50879: Fix naming conventions for new lints
* #51011: rustdoc: hide macro export statements from docs
* #51051: prohibit turbofish in `impl Trait` methods
* #51052: restore emplacement syntax (obsolete)
* #51146: typeck: Do not pass the field check on field error
* #51235: remove notion of Implicit derefs from mem-cat

r? @ghost
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 2, 2018
@pietroalbini pietroalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 3, 2018
@pietroalbini
Copy link
Member

This PR failed to backport into the beta branch. The test run-pass-fulldeps/myriad-closures.rs failed to compile on i686 Windows.

Can you check this @nox?

@nox
Copy link
Contributor Author

nox commented Jun 7, 2018

Nope, I don't have a Windows box.

@pietroalbini pietroalbini removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 7, 2018
@eddyb
Copy link
Member

eddyb commented Jun 7, 2018

As mentioned in #49873 (comment), it's possible this is a resource exhaustion problem (with 32-bit windows having possibly the lowest resource limits, so it's the first/only target to fail).

@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 12, 2018
@pietroalbini
Copy link
Member

The backport is no longer needed (see #49873 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust 1.25.0 regressed the performance of encoding_rs's UTF-8 validation on i686
10 participants