Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert(true) and assert(false) lints #3582

Merged
merged 9 commits into from
Jan 23, 2019
Merged

Add assert(true) and assert(false) lints #3582

merged 9 commits into from
Jan 23, 2019

Commits on Jan 7, 2019

  1. Add assert(true) and assert(false) lints

    A.A.Abroskin committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    98c5f37 View commit details
    Browse the repository at this point in the history

  2. Add unreachable!() as option

    A.A.Abroskin committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    3d9535a View commit details
    Browse the repository at this point in the history

  3. run ./util/dev update_lints

    A.A.Abroskin committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    9605861 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. change assert_checks to assertions_on_constants

    A.A.Abroskin committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    906b516 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add-lints-aseert-checks

    Abroskin Alexander authored Jan 9, 2019
    Configuration menu
    Copy the full SHA
    7075015 View commit details
    Browse the repository at this point in the history

  3. add assert(true/false, some message) tests

    A.A.Abroskin committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    a9f8d3c View commit details
    Browse the repository at this point in the history

  4. run ./util/dev update_lints

    A.A.Abroskin committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    58abdb5 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Merge branch 'master' into add-lints-aseert-checks 

    * master: (58 commits)
  Rustfmt all the things
  Don't make decisions on values that don't represent the decision
  Improving comments.
  Rustup
  Added rustfix to the test.
  Improve span shortening.
  Added "make_return" and "blockify" convenience methods in Sugg and used them in "needless_bool".
  Actually check for constants.
  Fixed potential mistakes with nesting. Added tests.
  formatting fix
  Update clippy_lints/src/needless_bool.rs
  formatting fix
  Fixing typo in CONTRIBUTING.md
  Fix breakage due to rust-lang/rust#57651
  needless bool lint suggestion is wrapped in brackets if it is an "else" clause of an "if-else" statement
  Fix automatic suggestion on `use_self`.
  Remove negative integer literal checks.
  Fix `implicit_return` false positives.
  Run rustfmt
  Fixed breakage due to rust-lang/rust#57489
  ...
    A.A.Abroskin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f11d993 View commit details
    Browse the repository at this point in the history

  2. allow assertions_on_constants for collapsible_if and missing_test_files

    A.A.Abroskin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    c771f33 View commit details
    Browse the repository at this point in the history