Rollup of 4 pull requests #3686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed them in "needless_bool".
Co-Authored-By: daxpedda <1645124+daxpedda@users.noreply.github.com>
Fix automatic suggestion on `use_self`.
In an example like this:
```rust
impl Example {
fn fun_1() { }
fn fun_2() {
Example::fun_1();
}
}
```
Clippy tries to replace `Example::fun_1` with `Self`, loosing `::fun_1` in the process, it should rather try to replace `Example` with `Self`.
**Question**
- There may be other paths that need the same treatment, but I'm not sure I understand them fully:
- https://github.com/rust-lang/rust-clippy/blob/e648adf0866a1cea7db6ce2d33ea86e442f25377/clippy_lints/src/use_self.rs#L94-L96
- https://github.com/rust-lang/rust-clippy/blob/e648adf0866a1cea7db6ce2d33ea86e442f25377/clippy_lints/src/use_self.rs#L225-L229
…lip1995 Add assert(true) and assert(false) lints This PR add two lints on assert!(true) and assert!(false). rust-lang#3575
…ns, r=oli-obk "make_return" and "blockify" convenience methods, fixes rust-lang#3683 …ed them in "needless_bool".
|
@bors r+ p=10 |
|
📌 Commit bd6e510 has been approved by |
|
💔 Test failed - checks-travis |
|
@bors r- |
|
@bors r- p=0 |
|
@bors clean |
|
@bors ping |
|
😪 I'm awake I'm awake |
|
@bors force clean |
|
Hmm, this PR is stuck in the queue... I can't figure out how to get it out of the queue 🤔 |
|
Maybe reopening and closing could work? |
|
Can't, the branch changed while it was closed, so it's stuck |
|
I'm going to synchronize |
|
It's fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
use_self. #3679 (Fix automatic suggestion onuse_self.)Suggstructured snippet modifications wishlist #3683)Failed merges:
r? @ghost