Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #3686

Closed
wants to merge 20 commits into from
Closed

Rollup of 4 pull requests #3686

wants to merge 20 commits into from

Commits on Jan 7, 2019

  1. Add assert(true) and assert(false) lints

    A.A.Abroskin committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    98c5f37 View commit details
    Browse the repository at this point in the history
  2. Add unreachable!() as option

    A.A.Abroskin committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    3d9535a View commit details
    Browse the repository at this point in the history
  3. run ./util/dev update_lints

    A.A.Abroskin committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    9605861 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. change assert_checks to assertions_on_constants

    A.A.Abroskin committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    906b516 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into add-lints-aseert-checks

    Abroskin Alexander authored Jan 9, 2019
    Configuration menu
    Copy the full SHA
    7075015 View commit details
    Browse the repository at this point in the history
  3. add assert(true/false, some message) tests

    A.A.Abroskin committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    a9f8d3c View commit details
    Browse the repository at this point in the history
  4. run ./util/dev update_lints

    A.A.Abroskin committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    58abdb5 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2019

  1. Configuration menu
    Copy the full SHA
    13b5ea4 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. Configuration menu
    Copy the full SHA
    2e0977f View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Added "make_return" and "blockify" convenience methods in Sugg and us…

    …ed them in "needless_bool".
    Grzegorz Bartoszek committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    0f5c43a View commit details
    Browse the repository at this point in the history
  2. Improve span shortening.

    Co-Authored-By: daxpedda <1645124+daxpedda@users.noreply.github.com>
    flip1995 and daxpedda authored Jan 22, 2019
    Configuration menu
    Copy the full SHA
    e70f945 View commit details
    Browse the repository at this point in the history
  3. Added rustfix to the test.

    daxpedda committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    e6f2239 View commit details
    Browse the repository at this point in the history
  4. Rustup

    oli-obk committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    3168023 View commit details
    Browse the repository at this point in the history
  5. Improving comments.

    daxpedda committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    42d5a07 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    38cdf63 View commit details
    Browse the repository at this point in the history
  7. Rustfmt all the things

    oli-obk committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    d6c8063 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#3679 - daxpedda:use_self, r=oli-obk

    Fix automatic suggestion on `use_self`.
    
    In an example like this:
    ```rust
    impl Example {
        fn fun_1() { }
        fn fun_2() {
            Example::fun_1();
        }
    }
    ```
    Clippy tries to replace `Example::fun_1` with `Self`, loosing `::fun_1` in the process, it should rather try to replace `Example` with `Self`.
    
    **Question**
    - There may be other paths that need the same treatment, but I'm not sure I understand them fully:
      - https://github.com/rust-lang/rust-clippy/blob/e648adf0866a1cea7db6ce2d33ea86e442f25377/clippy_lints/src/use_self.rs#L94-L96
      - https://github.com/rust-lang/rust-clippy/blob/e648adf0866a1cea7db6ce2d33ea86e442f25377/clippy_lints/src/use_self.rs#L225-L229
    flip1995 authored Jan 22, 2019
    Configuration menu
    Copy the full SHA
    0eb0000 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#3582 - Arkweid:add-lints-aseert-checks, r=f…

    …lip1995
    
    Add assert(true) and assert(false) lints
    
    This PR add two lints on assert!(true) and assert!(false).
    rust-lang#3575
    flip1995 authored Jan 22, 2019
    Configuration menu
    Copy the full SHA
    d342761 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#3684 - g-bartoszek:sugg-snippet-modificatio…

    …ns, r=oli-obk
    
    "make_return" and "blockify" convenience methods, fixes rust-lang#3683
    
    …ed them in "needless_bool".
    flip1995 authored Jan 22, 2019
    Configuration menu
    Copy the full SHA
    1e672af View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bd6e510 View commit details
    Browse the repository at this point in the history