Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop exporting amain for android. #10875

Closed
ILyoan opened this issue Dec 9, 2013 · 3 comments
Closed

Stop exporting amain for android. #10875

ILyoan opened this issue Dec 9, 2013 · 3 comments
Labels
O-android Operating system: Android

Comments

@ILyoan
Copy link
Contributor

ILyoan commented Dec 9, 2013

rustc exports amain when build library for android to provide an start point that initiate rust runtime.
Now we have start_on_main_thread exported publicaly, a rust library is able to provide an entry function without amain hack .

#[no_mangle]
pub extern fn entry(argc: int, argv: **u8) -> int {
    do std::rt::start_on_main_thread(argc, argv) {
        // do what you want.
    }
}

Thus I don't think we need amain hack any longer.

@ILyoan
Copy link
Contributor Author

ILyoan commented Dec 9, 2013

Related to #4404

@alexcrichton
Copy link
Member

Does this also mean that we could remove the logic of sometimes naming the entry point main and sometimes amain?

@ILyoan
Copy link
Contributor Author

ILyoan commented Dec 11, 2013

@alexcrichton Yes.
I don't think android libraries need an entry point to start runtime at all. we can remove all related code tagged as "FIXME #4404"

flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
…p1995

Adapt versions.html file to cleaned up gh-pages

Companion PR to rust-lang#10875

changelog: Remove legacy v0.0.* versions from Clippy repository and documentation.

Must be merged together with rust-lang#10875 (best with a closed tree)

r? `@Alexendoo` (because you were randomly selected on the other PR :P)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-android Operating system: Android
Projects
None yet
Development

No branches or pull requests

2 participants