A few small issue fixes #10915
Merged
A few small issue fixes #10915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should someone test the last commit on an android machine since I don't think bors actually runs any executables on android (iirc)? |
|
Is #4404 still relevant? |
| @@ -140,6 +141,10 @@ impl ParserObsoleteMethods for Parser { | |||
| "closures are now written `|A| -> B` rather than `&fn(A) -> \ | |||
| B`." | |||
| ), | |||
| ObsoleteMultipleImport => ( | |||
| "multiple imports", | |||
| "imports should be one per `use` statement" | |||
There was a problem hiding this comment.
This should maybe talk about the new syntax introduced in #10808?
|
Rebased with issues addressed |
|
Looks good to me other than the misspell. Thanks |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…as,xFrednet New lint [`min_ident_chars`] Closes rust-lang#10915 This also implements `WithSearchPat` for `Ident`, as I was going to rewrite this as a late lint to optionally ignore fields and/or generics but this was more complex than anticipated changelog: New lint [`min_ident_chars`] [rust-lang#10916](rust-lang/rust-clippy#10916)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little cleanup.