Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "alloc: Allow comparing Boxs over different allocators", add regression test #113318

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jul 4, 2023

Temporary fix for #113283

Adds a test to fix the regression introduced in 001b081 and revert that commit. The test fails without the revert.

@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 4, 2023
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 4, 2023

r? @joshtriplett

(reviewer of the original commit)

…st-lang#113283)

Verify that `PartialEq` implementations do not break type inference
when comparing types across different allocators. This catches a
regression in current nightly introduced in 001b081 (alloc: Allow
comparing `Box`s over different allocators")

`Box` is the only type that currently impelements this, but tests are
included for `Rc` and `Arc` to prevent future regresssions.
This reverts commit 001b081.

This change was done as the above commit introduces a regression in type
inference. Regression test located at
`tests/ui/type-inference/issue-113283-alllocator-trait-eq.rs`
@tgross35 tgross35 changed the title Add a test for PartialEq across Allocators breaking inference, revert this commit Add a test for PartialEq across Allocators breaking inference, revert the relevant commit Jul 4, 2023
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 4, 2023

@rustbot label -T-libs +T-libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 4, 2023
@tgross35 tgross35 changed the title Add a test for PartialEq across Allocators breaking inference, revert the relevant commit Revert "alloc: Allow comparing Boxs over different allocators", add regression test Jul 4, 2023
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 5, 2023

Vec has a similar different allocator partialeq. I can't come up with a test that produces this same failure though.

@m-ou-se
Copy link
Member

m-ou-se commented Jul 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2023

📌 Commit a635bf7 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2023
@m-ou-se m-ou-se added this to the 1.72.0 milestone Jul 6, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2023
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#111917 (Simplify duplicate checks for mir validator)
 - rust-lang#112008 (Fix incorrect documented default bufsize in bufreader/writer)
 - rust-lang#112825 (Don't call `type_of` on TAIT in defining scope in new solver)
 - rust-lang#113164 (Add a regression test for rust-lang#109054)
 - rust-lang#113318 (Revert "alloc: Allow comparing Boxs over different allocators", add regression test)
 - rust-lang#113397 (Prefer object candidates in new selection)
 - rust-lang#113419 (Avoid calling item_name for RPITIT)
 - rust-lang#113421 (Do not assert >1 RPITITs on collect_return_position_impl_trait_in_trait_tys)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7913d76 into rust-lang:master Jul 7, 2023
smoelius added a commit to trailofbits/necessist that referenced this pull request Jul 7, 2023
smoelius added a commit to trailofbits/necessist that referenced this pull request Jul 7, 2023
smoelius added a commit to trailofbits/necessist that referenced this pull request Jul 10, 2023
@tgross35 tgross35 deleted the 113283-allocator-trait-eq branch August 14, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants