Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "alloc: Allow comparing Boxs over different allocators", add regression test #113318

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Revert "alloc: Allow comparing Boxs over different allocators", add regression test #113318

merged 2 commits into from
Jul 7, 2023

Commits on Jul 4, 2023

  1. Add a test for PartialEq across Allocators breaking inference (ru… 

    …st-lang#113283)

Verify that `PartialEq` implementations do not break type inference
when comparing types across different allocators. This catches a
regression in current nightly introduced in 001b081 (alloc: Allow
comparing `Box`s over different allocators")

`Box` is the only type that currently impelements this, but tests are
included for `Rc` and `Arc` to prevent future regresssions.
    @tgross35
    tgross35 committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3c9a749 View commit details
    Browse the repository at this point in the history

  2. Revert "alloc: Allow comparing Boxs over different allocators" 

    This reverts commit 001b081.

This change was done as the above commit introduces a regression in type
inference. Regression test located at
`tests/ui/type-inference/issue-113283-alllocator-trait-eq.rs`
    @tgross35
    tgross35 committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a635bf7 View commit details
    Browse the repository at this point in the history