Fully stop using the HIR in trait impl checks

[oli-obk]

At least I hope I found all happy path usages. I'll need to check if I can figure out a way to make queries declare that they don't access the HIR except in error paths

[rustbot]

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 7320623 with merge 26395ac...

[bors]

☀️ Try build successful - checks-actions
Build commit: 26395ac (26395ac41adf5e6a3bbc5b2032abe3d5688e3c0b)

[rust-timer]

Finished benchmarking commit (26395ac): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.9%	[5.9%, 5.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	27
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	27

Bootstrap: 662.695s -> 663.778s (0.16%)
Artifact size: 308.49 MiB -> 308.41 MiB (-0.03%)

[TaKO8Ki]

@bors r+

[bors]

📌 Commit 7320623 has been approved by TaKO8Ki

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7320623 with merge bb89df6...

[bors]

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing bb89df6 to master...

[rust-timer]

Finished benchmarking commit (bb89df6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	23
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	23

Bootstrap: 632.386s -> 632.818s (0.07%)
Artifact size: 306.13 MiB -> 306.16 MiB (0.01%)