Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully stop using the HIR in trait impl checks #121018

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Fully stop using the HIR in trait impl checks #121018

merged 6 commits into from
Feb 14, 2024

Commits on Feb 13, 2024

  1. Store impl unsafety in impl trait header

    @oli-obk
    oli-obk committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    11a73f6 View commit details
    Browse the repository at this point in the history

  2. Invoke trait_def query only once 

    This may be a small performance boost as we have to hash less to lookup the value
    @oli-obk
    oli-obk committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    55bbb05 View commit details
    Browse the repository at this point in the history

  3. Don't reinvoke trait_header query twice

    @oli-obk
    oli-obk committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    40b3cb0 View commit details
    Browse the repository at this point in the history

  4. Avoid using the HIR span in the happy path

    @oli-obk
    oli-obk committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    75de6cf View commit details
    Browse the repository at this point in the history

  5. Remove an impl_polarity call where the information is already avail… 

    …able in the header
    @oli-obk
    oli-obk committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    251c33c View commit details
    Browse the repository at this point in the history

  6. Just pass the checker instead of individual fields

    @oli-obk
    oli-obk committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7320623 View commit details
    Browse the repository at this point in the history