Fix incorrect trait privacy error #32073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's some seriously ugly code triplication in |
| @@ -498,7 +497,7 @@ impl<'a, 'tcx> PrivacyVisitor<'a, 'tcx> { | |||
| let node_id = if let Some(node_id) = self.tcx.map.as_local_node_id(did) { | |||
| node_id | |||
| } else { | |||
| if self.external_exports.contains(&did) { | |||
| if self.tcx.sess.cstore.visibility(did) == hir::Public { | |||
| debug!("privacy - {:?} was externally exported", did); | |||
| return Allowable; | |||
| } | |||
There was a problem hiding this comment.
Terrible triplication below this line. Could you clean it up?
|
@jseyfried Wonderful. I much prefer this fix to the old one :) |
|
@bors r+ |
|
📌 Commit b06a1cc has been approved by |
bors
added a commit
that referenced
this pull request
Mar 9, 2016
…ikomatsakis Fix incorrect trait privacy error This PR fixes #21670 by using the crate metadata instead of `ExternalExports` to determine if an external item is public. r? @nikomatsakis
Merged
This was referenced May 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #21670 by using the crate metadata instead of
ExternalExportsto determine if an external item is public.r? @nikomatsakis