Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect trait privacy error #32073

Merged
merged 4 commits into from
Mar 9, 2016
Merged

Fix incorrect trait privacy error #32073

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c63054d
Add method `visibility` to `CrateStore`
jseyfried Mar 5, 2016
cbae67a
Fix #21670
jseyfried Mar 6, 2016
2998564
Refactor away `ExternalExports`
jseyfried Mar 6, 2016
b06a1cc
Add regression test
jseyfried Mar 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix #21670
  • Loading branch information
@jseyfried
jseyfried committed Mar 6, 2016
commit cbae67aea7f1979251c855c0bd25f5b1a664b53a
3 changes: 2 additions & 1 deletion src/librustc_privacy/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ use rustc_front::intravisit::{self, Visitor};

use rustc::dep_graph::DepNode;
use rustc::lint;
use rustc::middle::cstore::CrateStore;
use rustc::middle::def::{self, Def};
use rustc::middle::def_id::DefId;
use rustc::middle::privacy::{AccessLevel, AccessLevels};
Expand Down Expand Up @@ -498,7 +499,7 @@ impl<'a, 'tcx> PrivacyVisitor<'a, 'tcx> {
let node_id = if let Some(node_id) = self.tcx.map.as_local_node_id(did) {
node_id
} else {
if self.external_exports.contains(&did) {
if self.tcx.sess.cstore.visibility(did) == hir::Public {
debug!("privacy - {:?} was externally exported", did);
return Allowable;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrible triplication below this line. Could you clean it up?

Expand Down