Stabilize more APIs for the 1.20.0 release #43373

alexcrichton · 2017-07-20T22:56:10Z

In addition to the few stabilizations that have already landed, this cleans up the remaining APIs that are in final-comment-period right now to be stable by the 1.20.0 release

alexcrichton · 2017-07-20T22:56:40Z

Note that I've explicitly omitted RangeArgument as I believe there's still activity happening on that.

alexcrichton · 2017-07-20T22:57:09Z

r? @aturon

alexcrichton · 2017-07-20T22:57:13Z

(or @sfackler)

kennytm · 2017-07-21T02:07:48Z

src/libsyntax/feature_gate.rs

@@ -445,6 +444,8 @@ declare_features! (
    // Allows the definition of associated constants in `trait` or `impl`
    // blocks.
    (accepted, associated_consts, "1.20.0", Some(29646)),
+    // Usage of the `compile_error!` macro
+    (accepted, compile_error, "1.20.0", Some(40872)),


[00:04:22] error[E0026]: struct `feature_gate::Features` does not have a field named `compile_error` [00:04:22] --> /checkout/src/libsyntax/ext/expand.rs:1044:35 [00:04:22] | [00:04:22] 1013 | | Some(&Features { $field: true, .. }) => true, [00:04:22] | |__________________________________________________^ struct `feature_gate::Features` does not have field `compile_error` [00:04:22] ... [00:04:22] 1034 | |/ feature_tests! { [00:04:22] 1035 | || fn enable_quotes = quote, [00:04:22] 1036 | || fn enable_asm = asm, [00:04:22] 1037 | || fn enable_global_asm = global_asm, [00:04:22] ... || [00:04:22] 1044 | | fn enable_compile_error = compile_error, [00:04:22] | |___________________________________^ [00:04:22] 1045 | | } [00:04:22] | |_____- in this macro invocation [00:04:22] [00:04:22] error: aborting due to previous error(s) [00:04:22] [00:04:22] error: Could not compile `syntax`.

bors · 2017-07-22T18:30:58Z

☔ The latest upstream changes (presumably #43367) made this pull request unmergeable. Please resolve the merge conflicts.

aturon · 2017-07-25T05:48:25Z

LGTM. Fire at will.

kennytm · 2017-07-25T06:07:54Z

libstd doc tests failed.

[01:04:15] ---- ffi/c_str.rs - ffi::c_str::CStr::into_c_string (line 1003) stdout ----
[01:04:15] 	error: this feature has been stable since 1.20.0. Attribute no longer needed
[01:04:15]  --> <anon>:1:12
[01:04:15]   |
[01:04:15] 1 | #![feature(into_boxed_c_str)]
[01:04:15]   |            ^^^^^^^^^^^^^^^^
[01:04:15]   |
...
[01:04:15] failures:
[01:04:15]     ffi/c_str.rs - ffi::c_str::CStr::into_c_string (line 1003)
[01:04:15]     ffi/c_str.rs - ffi::c_str::CString::as_c_str (line 455)
[01:04:15]     ffi/c_str.rs - ffi::c_str::CString::into_boxed_c_str (line 476)
[01:04:15]     ffi/os_str.rs - ffi::os_str::OsString::into_boxed_os_str (line 254)

Stabilizes: * `<char>::escape_debug` * `std::char::EscapeDebug` Closes rust-lang#35068

Stabilized: * `Option::get_or_insert` * `Option::get_or_insert_with` Closes rust-lang#39288

Stabilized * `<str>::get` * `<str>::get_mut` * `<str>::get_unchecked` * `<str>::get_unchecked_mut` Closes rust-lang#39932

Stabilizes: * `CString::as_c_str` * `CString::into_boxed_c_str` * `CStr::into_c_string` * `OsString::into_boxed_os_str` * `OsStr::into_os_string` * `PathBuf::into_boxed_path` * `PathBuf::into_path_buf` Closes rust-lang#40380

Stabilizes: * `Utf8Error::error_len` Closes rust-lang#40494

Stabilizes * `core::mem::ManuallyDrop` * `std::mem::ManuallyDrop` * `ManuallyDrop::new` * `ManuallyDrop::into_inner` * `ManuallyDrop::drop` * `Deref for ManuallyDrop` * `DerefMut for ManuallyDrop` Closes rust-lang#40673

Stabilizes: * `compile_error!` as a macro defined by rustc Closes rust-lang#40872

Stabilizes * `<&mut str>::as_bytes_mut` * `<Box<str>>::into_boxed_bytes` * `std::str::from_boxed_utf8_unchecked` * `std::str::from_utf8_mut` * `std::str::from_utf8_unchecked_mut` Closes rust-lang#41119

alexcrichton · 2017-07-25T14:10:56Z

@bors: r=aturon

bors · 2017-07-25T14:10:57Z

📌 Commit 16707d4 has been approved by aturon

bors · 2017-07-26T07:48:19Z

⌛ Testing commit 16707d4 with merge de2eadaa672db502230b61325cd3afaa57fc2a59...

bors · 2017-07-26T09:24:09Z

💔 Test failed - status-travis

kennytm · 2017-07-26T09:42:11Z

x86_64-gnu-aux, #43453, spurious.

Mark-Simulacrum · 2017-07-26T11:56:01Z

@bors retry - #43453 RLS tests

bors · 2017-07-26T23:40:54Z

⌛ Testing commit 16707d4 with merge ddaab61...

Stabilize more APIs for the 1.20.0 release In addition to the few stabilizations that have already landed, this cleans up the remaining APIs that are in `final-comment-period` right now to be stable by the 1.20.0 release

bors · 2017-07-27T02:05:49Z

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing ddaab61 to master...

XAMPPRocky · 2017-08-04T12:08:20Z

@alexcrichton What does mean for impl SliceIndex<str> for Range* being stable when the SliceIndex trait is still unstable?

alexcrichton · 2017-08-05T03:20:09Z

@Aaronepower oh that's actually mostly irrelevant in terms of stabilization, the real stabilization here is methods like str::get that consume these impls.

Backporting accepted PRs to beta Backport of: * #43735 * #43546 * #43513 * #43373 * #43315

Correct a few stability attributes * The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0. * The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable. * The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable. * The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0. * The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.

alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 20, 2017

rust-highfive assigned aturon Jul 20, 2017

kennytm reviewed Jul 21, 2017

View reviewed changes

alexcrichton force-pushed the stabilize-1.20.0 branch 2 times, most recently from 79866b6 to b8ce384 Compare July 21, 2017 15:22

shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2017

alexcrichton force-pushed the stabilize-1.20.0 branch from b8ce384 to 093d38c Compare July 23, 2017 05:06

alexcrichton added 8 commits July 25, 2017 07:09

std: Stabilize char_escape_debug

4c9c6e8

Stabilizes: * `<char>::escape_debug` * `std::char::EscapeDebug` Closes rust-lang#35068

std: Stabilize option_entry feature

64c1b23

Stabilized: * `Option::get_or_insert` * `Option::get_or_insert_with` Closes rust-lang#39288

std: Stabilize str_checked_slicing feature

46de2af

Stabilized * `<str>::get` * `<str>::get_mut` * `<str>::get_unchecked` * `<str>::get_unchecked_mut` Closes rust-lang#39932

std: Stabilize CString/OsString/PathBuf extra methods

cbfce40

Stabilizes: * `CString::as_c_str` * `CString::into_boxed_c_str` * `CStr::into_c_string` * `OsString::into_boxed_os_str` * `OsStr::into_os_string` * `PathBuf::into_boxed_path` * `PathBuf::into_path_buf` Closes rust-lang#40380

std: Stabilize utf8_error_error_len feature

3fae481

Stabilizes: * `Utf8Error::error_len` Closes rust-lang#40494

std: Stabilize manually_drop feature

daeb607

Stabilizes * `core::mem::ManuallyDrop` * `std::mem::ManuallyDrop` * `ManuallyDrop::new` * `ManuallyDrop::into_inner` * `ManuallyDrop::drop` * `Deref for ManuallyDrop` * `DerefMut for ManuallyDrop` Closes rust-lang#40673

Stabilize the compile_error_macro feature

20b4f86

Stabilizes: * `compile_error!` as a macro defined by rustc Closes rust-lang#40872

std: Stabilize the str_{mut,box}_extras feature

16707d4

Stabilizes * `<&mut str>::as_bytes_mut` * `<Box<str>>::into_boxed_bytes` * `std::str::from_boxed_utf8_unchecked` * `std::str::from_utf8_mut` * `std::str::from_utf8_unchecked_mut` Closes rust-lang#41119

alexcrichton force-pushed the stabilize-1.20.0 branch from 093d38c to 16707d4 Compare July 25, 2017 14:10

bors merged commit 16707d4 into rust-lang:master Jul 27, 2017

bors mentioned this pull request Jul 27, 2017

Generator support #43076

Merged

7 tasks

wesleywiser mentioned this pull request Aug 3, 2017

Updated release notes for 1.20 #43627

Merged

alexcrichton deleted the stabilize-1.20.0 branch August 5, 2017 03:19

alexcrichton mentioned this pull request Aug 12, 2017

Backporting accepted PRs to beta #43831

Merged

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 12, 2017

bors added a commit that referenced this pull request Aug 13, 2017

Auto merge of #43831 - alexcrichton:beta-next, r=alexcrichton

54279df

Backporting accepted PRs to beta Backport of: * #43735 * #43546 * #43513 * #43373 * #43315

ollie27 mentioned this pull request Dec 27, 2017

Correct a few stability attributes #47030

Merged

ErichDonGubler mentioned this pull request Mar 19, 2018

Tracking issue for the FromUtf8Error::as_bytes #40895

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize more APIs for the 1.20.0 release #43373

Stabilize more APIs for the 1.20.0 release #43373

alexcrichton commented Jul 20, 2017

alexcrichton commented Jul 20, 2017

alexcrichton commented Jul 20, 2017

alexcrichton commented Jul 20, 2017

kennytm Jul 21, 2017

bors commented Jul 22, 2017

aturon commented Jul 25, 2017

kennytm commented Jul 25, 2017

alexcrichton commented Jul 25, 2017

bors commented Jul 25, 2017

bors commented Jul 26, 2017

bors commented Jul 26, 2017

kennytm commented Jul 26, 2017

Mark-Simulacrum commented Jul 26, 2017

bors commented Jul 26, 2017

bors commented Jul 27, 2017

XAMPPRocky commented Aug 4, 2017

alexcrichton commented Aug 5, 2017

Stabilize more APIs for the 1.20.0 release #43373

Stabilize more APIs for the 1.20.0 release #43373

Conversation

alexcrichton commented Jul 20, 2017

alexcrichton commented Jul 20, 2017

alexcrichton commented Jul 20, 2017

alexcrichton commented Jul 20, 2017

kennytm Jul 21, 2017

Choose a reason for hiding this comment

bors commented Jul 22, 2017

aturon commented Jul 25, 2017

kennytm commented Jul 25, 2017

alexcrichton commented Jul 25, 2017

bors commented Jul 25, 2017

bors commented Jul 26, 2017

bors commented Jul 26, 2017

kennytm commented Jul 26, 2017

Mark-Simulacrum commented Jul 26, 2017

bors commented Jul 26, 2017

bors commented Jul 27, 2017

XAMPPRocky commented Aug 4, 2017

alexcrichton commented Aug 5, 2017