Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From for Mutex and RwLock #46082

Merged
merged 2 commits into from
Nov 21, 2017
Merged

impl From for Mutex and RwLock #46082

merged 2 commits into from
Nov 21, 2017

Conversation

Enet4
Copy link
Contributor

@Enet4 Enet4 commented Nov 18, 2017 •
edited
Loading

I felt that these implementations were missing, because doing x.into() works for other smart containers (such as RefCell), and in general I would say that the conversion makes sense.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 18, 2017
@kennytm
Copy link
Member

kennytm commented Nov 18, 2017

What about RwLock?

@Enet4
Copy link
Contributor Author

Enet4 commented Nov 18, 2017 •
edited
Loading

@kennytm Hmm, that might be a good candidate as well. I'll look into it in a few hours. Done.

@Enet4 Enet4 changed the title impl From for Mutex impl From for Mutex and RwLock Nov 18, 2017
@sfackler
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2017

📌 Commit 0855ea1 has been approved by sfackler

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2017
@kennytm kennytm mentioned this pull request Nov 20, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Nov 20, 2017
@kennytm
Rollup merge of rust-lang#46082 - Enet4:mutex_from, r=sfackler
2c16502 
impl From for Mutex and RwLock

I felt that these implementations were missing, because doing `x.into()` works for other smart containers (such as `RefCell`), and in general I would say that the conversion makes sense.
@kennytm kennytm mentioned this pull request Nov 20, 2017
Merged
bors added a commit that referenced this pull request Nov 20, 2017
@bors
Auto merge of #46130 - kennytm:rollup, r=kennytm
1e44fee 
Rollup of 9 pull requests

- Successful merges: #46082, #46088, #46092, #46107, #46119, #46121, #46122, #46124, #46128
- Failed merges:
@bors
Copy link
Contributor

bors commented Nov 21, 2017

☔ The latest upstream changes (presumably #46130) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 0855ea1 into rust-lang:master Nov 21, 2017
@ollie27 ollie27 mentioned this pull request Dec 27, 2017
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 4, 2018
@steveklabnik
Rollup merge of rust-lang#47030 - ollie27:stab, r=alexcrichton
b6f7484 
Correct a few stability attributes

* The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0.
* The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable.
* The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable.
* The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0.
* The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
kennytm added a commit to kennytm/rust that referenced this pull request Jan 4, 2018
@kennytm
Rollup merge of rust-lang#47030 - ollie27:stab, r=alexcrichton
f2d9035 
Correct a few stability attributes

* The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0.
* The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable.
* The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable.
* The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0.
* The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
kennytm added a commit to kennytm/rust that referenced this pull request Jan 5, 2018
@kennytm
Rollup merge of rust-lang#47030 - ollie27:stab, r=alexcrichton
63c8e0c 
Correct a few stability attributes

* The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0.
* The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable.
* The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable.
* The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0.
* The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Enet4 @kennytm @sfackler @bors