Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FnBox #62043

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Remove FnBox #62043

merged 1 commit into from
Jun 28, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jun 22, 2019

Remove FnBox since we now have Box<dyn FnOnce>.

Closes #28796.

r? @cramertj

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2019
@cramertj
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 26, 2019

📌 Commit a99a7b7 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 26, 2019
Remove `FnBox`

Remove `FnBox` since we now have `Box<dyn FnOnce>`.

Closes rust-lang#28796.

r? @cramertj
bors added a commit that referenced this pull request Jun 26, 2019
Rollup of 8 pull requests

Successful merges:

 - #60340 (Rename .cap() methods to .capacity())
 - #61767 (Update new_debug_unreachable)
 - #62043 (Remove `FnBox`)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62104 (Inform the query system about properties of queries at compile time)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jun 26, 2019
Remove `FnBox`

Remove `FnBox` since we now have `Box<dyn FnOnce>`.

Closes rust-lang#28796.

r? @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Remove `FnBox`

Remove `FnBox` since we now have `Box<dyn FnOnce>`.

Closes rust-lang#28796.

r? @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Remove `FnBox`

Remove `FnBox` since we now have `Box<dyn FnOnce>`.

Closes rust-lang#28796.

r? @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Remove `FnBox`

Remove `FnBox` since we now have `Box<dyn FnOnce>`.

Closes rust-lang#28796.

r? @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Remove `FnBox`

Remove `FnBox` since we now have `Box<dyn FnOnce>`.

Closes rust-lang#28796.

r? @cramertj
bors added a commit that referenced this pull request Jun 28, 2019
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62067 (Add suggestion for missing `.await` keyword)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost
@bors bors merged commit a99a7b7 into rust-lang:master Jun 28, 2019
@Centril Centril deleted the remove-fnbox branch June 28, 2019 17:36
ramosbugs pushed a commit to commure/datatest that referenced this pull request Jul 2, 2019
Support latest nightly after
rust-lang/rust#62043 was merged.
ramosbugs added a commit to commure/datatest that referenced this pull request Jul 2, 2019
Support latest nightly after
rust-lang/rust#62043 was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for FnBox()
4 participants