Rollup of 16 pull requests

[Centril]

Successful merges:

• improve pinning projection docs #61878 (improve pinning projection docs)
• Remove FnBox #62043 (Remove FnBox)
• Add suggestion for missing .await keyword #62067 (Add suggestion for missing .await keyword)
• Updated RELEASES.md for 1.36.0 #62076 (Updated RELEASES.md for 1.36.0)
• call out explicitly that general read needs to be called with an initialized buffer #62102 (call out explicitly that general read needs to be called with an initialized buffer)
• Add more tests for async/await #62106 (Add more tests for async/await)
• refactor lexer to use idiomatic borrowing #62124 (refactor lexer to use idiomatic borrowing)
• Implement mem::{zeroed,uninitialized} in terms of MaybeUninit. #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
• Don't ICE on item in .await expression #62152 (Don't ICE on item in .await expression)
• Remove old fixme #62154 (Remove old fixme)
• Add regression test for MIR drop generation in async loops #62155 (Add regression test for MIR drop generation in async loops)
• Update books #62156 (Update books)
• Remove outdated question_mark_macro_sep lint #62160 (Remove outdated question_mark_macro_sep lint)
• save-analysis: use buffered writes #62164 (save-analysis: use buffered writes)
• rustc: Retry SIGILL linker invocations #62171 (rustc: Retry SIGILL linker invocations)
• Update RLS #62176 (Update RLS)

Failed merges:

r? @ghost

[Centril]

@bors r+ p=16 rollup=never

[bors]

📌 Commit 24a356f has been approved by Centril

[bors]

⌛ Testing commit 24a356f with merge a0de724a4ddcc990b565da246e347a4c59456397...

[bors]

💔 Test failed - checks-travis

[rust-highfive]

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:28:59]    |
[01:28:59] LL |     let ref_uninit: &T = std::intrinsics::uninit(); // warning
[01:28:59]    |                                           ^^^^^^ help: a function with a similar name exists: `init`
[01:28:59] 
[01:28:59] error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead
[01:28:59]    |
[01:28:59] LL | use std::intrinsics::{init, uninit};
[01:28:59]    |                       ^^^^
[01:28:59]    |
[01:28:59]    |
[01:28:59]    = note: `-D deprecated` implied by `-D warnings`
[01:28:59] 
[01:28:59] error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead
[01:28:59]    |
[01:28:59]    |
[01:28:59] LL |     let ref_zero: &T = std::intrinsics::init(); // warning
[01:28:59] 
[01:28:59] 
[01:28:59] error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead
[01:28:59]    |
[01:28:59]    |
[01:28:59] LL |     let mem_zero: usize = std::intrinsics::init(); // no warning
[01:28:59] 
[01:28:59] error: aborting due to 5 previous errors
[01:28:59] 
[01:28:59] Some errors have detailed explanations: E0425, E0432.
[01:28:59] Some errors have detailed explanations: E0425, E0432.
[01:28:59] For more information about an error, try `rustc --explain E0425`.
[01:28:59] 
[01:28:59] 
[01:28:59] expected stderr:
[01:28:59] error: reference to zeroed memory
[01:28:59]   --> $DIR/invalid_ref.rs:24:24
[01:28:59]    |
[01:28:59] LL |     let ref_zero: &T = std::mem::zeroed(); // warning
[01:28:59]    |
[01:28:59]    = note: #[deny(clippy::invalid_ref)] on by default
[01:28:59]    = note: #[deny(clippy::invalid_ref)] on by default
[01:28:59]    = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] error: reference to zeroed memory
[01:28:59]   --> $DIR/invalid_ref.rs:28:24
[01:28:59]    |
[01:28:59]    |
[01:28:59] LL |     let ref_zero: &T = core::mem::zeroed(); // warning
[01:28:59]    |
[01:28:59]    |
[01:28:59]    = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] error: reference to zeroed memory
[01:28:59]   --> $DIR/invalid_ref.rs:32:24
[01:28:59]    |
[01:28:59]    |
[01:28:59] LL |     let ref_zero: &T = std::intrinsics::init(); // warning
[01:28:59]    |
[01:28:59]    |
[01:28:59]    = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] error: reference to uninitialized memory
[01:28:59]   --> $DIR/invalid_ref.rs:36:26
[01:28:59]    |
[01:28:59] LL |     let ref_uninit: &T = std::mem::uninitialized(); // warning
[01:28:59] LL |     let ref_uninit: &T = std::mem::uninitialized(); // warning
[01:28:59]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^
[01:28:59]    |
[01:28:59]    = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] error: reference to uninitialized memory
[01:28:59]   --> $DIR/invalid_ref.rs:40:26
[01:28:59]    |
[01:28:59] LL |     let ref_uninit: &T = core::mem::uninitialized(); // warning
[01:28:59] LL |     let ref_uninit: &T = core::mem::uninitialized(); // warning
[01:28:59]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:28:59]    |
[01:28:59]    = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] error: reference to uninitialized memory
[01:28:59]   --> $DIR/invalid_ref.rs:44:26
[01:28:59]    |
[01:28:59] LL |     let ref_uninit: &T = std::intrinsics::uninit(); // warning
[01:28:59] LL |     let ref_uninit: &T = std::intrinsics::uninit(); // warning
[01:28:59]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^
[01:28:59]    |
[01:28:59]    = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] error: aborting due to 6 previous errors
[01:28:59] 
[01:28:59] 
[01:28:59] 
[01:28:59] 
[01:28:59] diff of stderr:
[01:28:59] 
[01:28:59] -error: reference to zeroed memory
[01:28:59] -  --> $DIR/invalid_ref.rs:24:24
[01:28:59] +error[E0432]: unresolved import `std::intrinsics::uninit`
[01:28:59] +  --> $DIR/invalid_ref.rs:5:29
[01:28:59]     |
[01:28:59] -LL |     let ref_zero: &T = std::mem::zeroed(); // warning
[01:28:59] +LL | use std::intrinsics::{init, uninit};
[01:28:59] +   |                             ^^^^^^
[01:28:59] +   |                             |
[01:28:59] +   |                             no `uninit` in `intrinsics`
[01:28:59] +   |                             no `uninit` in `intrinsics`
[01:28:59] +   |                             help: a similar name exists in the module: `init`
[01:28:59] +
[01:28:59] +error[E0425]: cannot find function `uninit` in module `std::intrinsics`
[01:28:59] +  --> $DIR/invalid_ref.rs:44:43
[01:28:59]     |
[01:28:59] -   = note: #[deny(clippy::invalid_ref)] on by default
[01:28:59] -   = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] +LL |     let ref_uninit: &T = std::intrinsics::uninit(); // warning
[01:28:59]  
[01:28:59] -error: reference to zeroed memory
[01:28:59] -  --> $DIR/invalid_ref.rs:28:24
[01:28:59] -  --> $DIR/invalid_ref.rs:28:24
[01:28:59] +error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead
[01:28:59]     |
[01:28:59]     |
[01:28:59] -LL |     let ref_zero: &T = core::mem::zeroed(); // warning
[01:28:59] +LL | use std::intrinsics::{init, uninit};
[01:28:59] +   |                       ^^^^
[01:28:59]     |
[01:28:59]     |
[01:28:59] -   = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59]  
[01:28:59] -error: reference to zeroed memory
[01:28:59] -error: reference to zeroed memory
[01:28:59] +error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead
[01:28:59]     |
[01:28:59]     |
[01:28:59]  LL |     let ref_zero: &T = std::intrinsics::init(); // warning
[01:28:59] -   |
[01:28:59] -   |
[01:28:59] -   = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59]  
[01:28:59] -error: reference to uninitialized memory
[01:28:59] -  --> $DIR/invalid_ref.rs:36:26
[01:28:59] -  --> $DIR/invalid_ref.rs:36:26
[01:28:59] +error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead
[01:28:59]     |
[01:28:59] -LL |     let ref_uninit: &T = std::mem::uninitialized(); // warning
[01:28:59] -   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^
[01:28:59] -   |
[01:28:59] -   |
[01:28:59] -   = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] +LL |     let mem_zero: usize = std::intrinsics::init(); // no warning
[01:28:59]  
[01:28:59] -error: reference to uninitialized memory
[01:28:59] -  --> $DIR/invalid_ref.rs:40:26
[01:28:59] -   |
[01:28:59] -   |
[01:28:59] -LL |     let ref_uninit: &T = core::mem::uninitialized(); // warning
[01:28:59] -   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:28:59] -   |
[01:28:59] -   = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59]  
[01:28:59] -error: reference to uninitialized memory
[01:28:59] -  --> $DIR/invalid_ref.rs:44:26
[01:28:59] -   |
[01:28:59] -   |
[01:28:59] -LL |     let ref_uninit: &T = std::intrinsics::uninit(); // warning
[01:28:59] -   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^
[01:28:59] -   |
[01:28:59] -   = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html
[01:28:59] -error: aborting due to 6 previous errors
[01:28:59] -
[01:28:59] +Some errors have detailed explanations: E0425, E0432.
[01:28:59] +For more information about an error, try `rustc --explain E0425`.
---
[01:28:59] 
[01:28:59] ------------------------------------------
[01:28:59] stderr:
[01:28:59] ------------------------------------------
[01:28:59] {"message":"unresolved import `std::intrinsics::uninit`","code":{"code":"E0432","explanation":"\nAn import was unresolved.\n\nErroneous code example:\n\n```compile_fail,E0432\nuse something::Foo; // error: unresolved import `something::Foo`.\n```\n\nPaths in `use` statements are relative to the crate root. To import items\nrelative to the current and parent modules, use the `self::` and `super::`\nprefixes, respectively. Also verify that you didn't misspell the import\nname and that the import exists in the module from where you tried to\nimport it. Example:\n\n```\nuse self::something::Foo; // ok!\n\nmod something {\n    pub struct Foo;\n}\n# fn main() {}\n```\n\nOr, if you tried to use a module from an external crate, you may have missed\nthe `extern crate` declaration (which is usually placed in the crate root):\n\n```\nextern crate core; // Required to use the `core` crate\n\nuse core::any;\n# fn main() {}\n```\n"},"level":"error","spans":[{"file_name":"tests/ui/invalid_ref.rs","byte_start":95,"byte_end":101,"line_start":5,"line_end":5,"column_start":29,"column_end":35,"is_primary":true,"text":[{"text":"use std::intrinsics::{init, uninit};","highlight_start":29,"highlight_end":35}],"label":"no `uninit` in `intrinsics`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"a similar name exists in the module","code":null,"level":"help","spans":[{"file_name":"tests/ui/invalid_ref.rs","byte_start":95,"byte_end":101,"line_start":5,"line_end":5,"column_start":29,"column_end":35,"is_primary":true,"text":[{"text":"use std::intrinsics::{init, uninit};","highlight_start":29,"highlight_end":35}],"label":null,"suggested_replacement":"init","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0432]: unresolved import `std::intrinsics::uninit`\n  --> tests/ui/invalid_ref.rs:5:29\n   |\nLL | use std::intrinsics::{init, uninit};\n   |                             ^^^^^^\n   |                             |\n   |                             no `uninit` in `intrinsics`\n   |                             help: a similar name exists in the module: `init`\n\n"}
[01:28:59] {"message":"cannot find function `uninit` in module `std::intrinsics`","code":{"code":"E0425","explanation":"\nAn unresolved name was used.\n\nErroneous code examples:\n\n```compile_fail,E0425\nsomething_that_doesnt_exist::foo;\n// error: unresolved name `something_that_doesnt_exist::foo`\n\n// or:\n\ntrait Foo {\n    fn bar() {\n        Self; // error: unresolved name `Self`\n    }\n}\n\n// or:\n\nlet x = unknown_variable;  // error: unresolved name `unknown_variable`\n```\n\nPlease verify that the name wasn't misspelled and ensure that the\nidentifier being referred to is valid for the given situation. Example:\n\n```\nenum something_that_does_exist {\n    Foo,\n}\n```\n\nOr:\n\n```\nmod something_that_does_exist {\n    pub static foo : i32 = 0i32;\n}\n\nsomething_that_does_exist::foo; // ok!\n```\n\nOr:\n\n```\nlet unknown_variable = 12u32;\nlet x = unknown_variable; // ok!\n```\n\nIf the item is not defined in the current module, it must be imported using a\n`use` statement, like so:\n\n```\n# mod foo { pub fn bar() {} }\n# fn main() {\nuse foo::bar;\nbar();\n# }\n```\n\nIf the item you are importing is not defined in some super-module of the\ncurrent module, then it must also be declared as public (e.g., `pub fn`).\n"},"level":"error","spans":[{"file_name":"tests/ui/invalid_ref.rs","byte_start":1095,"byte_end":1101,"line_start":44,"line_end":44,"column_start":43,"column_end":49,"is_primary":true,"text":[{"text":"    let ref_uninit: &T = std::intrinsics::uninit(); // warning","highlight_start":43,"highlight_end":49}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"a function with a similar name exists","code":null,"level":"help","spans":[{"file_name":"tests/ui/invalid_ref.rs","byte_start":1095,"byte_end":1101,"line_start":44,"line_end":44,"column_start":43,"column_end":49,"is_primary":true,"text":[{"text":"    let ref_uninit: &T = std::intrinsics::uninit(); // warning","highlight_start":43,"highlight_end":49}],"label":null,"suggested_replacement":"init","suggestion_applicability":"MaybeIncorrect","expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0425]: cannot find function `uninit` in module `std::intrinsics`\n  --> tests/ui/invalid_ref.rs:44:43\n   |\nLL |     let ref_uninit: &T = std::intrinsics::uninit(); // warning\n   |                                           ^^^^^^ help: a function with a similar name exists: `init`\n\n"}
[01:28:59] {"message":"use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead","code":{"code":"deprecated","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/invalid_ref.rs","byte_start":89,"byte_end":93,"line_start":5,"line_end":5,"column_start":23,"column_end":27,"is_primary":true,"text":[{"text":"use std::intrinsics::{init, uninit};","highlight_start":23,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D deprecated` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead\n  --> tests/ui/invalid_ref.rs:5:23\n   |\nLL | use std::intrinsics::{init, uninit};\n   |                       ^^^^\n   |\n   = note: `-D deprecated` implied by `-D warnings`\n\n"}
[01:28:59] {"message":"use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead","code":{"code":"deprecated","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/invalid_ref.rs","byte_start":735,"byte_end":756,"line_start":32,"line_end":32,"column_start":24,"column_end":45,"is_primary":true,"text":[{"text":"    let ref_zero: &T = std::intrinsics::init(); // warning","highlight_start":24,"highlight_end":45}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead\n  --> tests/ui/invalid_ref.rs:32:24\n   |\nLL |     let ref_zero: &T = std::intrinsics::init(); // warning\n   |                        ^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:28:59] {"message":"use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead","code":{"code":"deprecated","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/invalid_ref.rs","byte_start":1410,"byte_end":1431,"line_start":60,"line_end":60,"column_start":27,"column_end":48,"is_primary":true,"text":[{"text":"    let mem_zero: usize = std::intrinsics::init(); // no warning","highlight_start":27,"highlight_end":48}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: use of deprecated item 'std::intrinsics::init': no longer used by rustc, will be removed - use MaybeUnint instead\n  --> tests/ui/invalid_ref.rs:60:27\n   |\nLL |     let mem_zero: usize = std::intrinsics::init(); // no warning\n   |                           ^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:28:59] {"message":"aborting due to 5 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 5 previous errors\n\n"}
[01:28:59] {"message":"Some errors have detailed explanations: E0425, E0432.","code":null,"level":"","spans":[],"children":[],"rendered":"Some errors have detailed explanations: E0425, E0432.\n"}
[01:28:59] 
[01:28:59] ------------------------------------------
[01:28:59] 
[01:28:59] thread '[ui] ui/invalid_ref.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/runtest.rs:2632:9
---
travis_time:end:013f9808:start=1561668751222386325,finish=1561668751230000364,duration=7614039
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:10b743b3
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:04d49416
travis_time:start:04d49416
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00105a95
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)