bootstrap: Improve wording on docs for verbose-tests
#74334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup=always |
|
@jyn514: 🔑 Insufficient privileges: not in try users |
|
Oh hmm I thought that only made a difference if the PR had already been reviewed. |
|
@bors r+ rollup=always |
|
📌 Commit ba661d8 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2020
…arth Rollup of 11 pull requests Successful merges: - rust-lang#73759 (Add missing Stdin and StdinLock examples) - rust-lang#74211 (Structured suggestion when not using struct pattern) - rust-lang#74228 (Provide structured suggestion on unsized fields and fn params) - rust-lang#74252 (Don't allow `DESTDIR` to influence LLVM builds) - rust-lang#74263 (Slight reorganization of sys/(fast_)thread_local) - rust-lang#74271 (process_unix: prefer i32::*_be_bytes over manually shifting bytes) - rust-lang#74272 (pprust: support multiline comments within lines) - rust-lang#74332 (Update cargo) - rust-lang#74334 (bootstrap: Improve wording on docs for `verbose-tests`) - rust-lang#74336 (typeck: use `item_name` in cross-crate packed diag) - rust-lang#74340 (lint: use `transparent_newtype_field` to avoid ICE) Failed merges: r? @ghost
eddyb
reviewed
Aug 30, 2020
| # Emits extraneous output from tests to ensure that failures of the test | ||
| # harness are debuggable just from logfiles. | ||
| # Emits extra output from tests so test failures are debuggable just from logfiles. |
There was a problem hiding this comment.
Quoting myself from rust-lang/rustc-dev-guide#795 (comment):
This change doesn't seem right, specifically "test harness" refers to the code running the tests, rather than the tests themselves. And it is extraneous for the common case of e.g.
libtestnot crashing.
There was a problem hiding this comment.
verbose tests indeed changes nothing about tests, only the harnesses (compiletest and libtest) which invoke them.
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Aug 31, 2020
This info was lost in rust-lang#74334.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 9, 2020
Address review comments about config.toml from rustc-dev-guide PR This info was lost in rust-lang#74334. See also rust-lang/rustc-dev-guide#795 (review). r? @Mark-Simulacrum or @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From rust-lang/rustc-dev-guide#795 (comment)
r? @spastorino