Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: Improve wording on docs for verbose-tests #74334

Merged
merged 1 commit into from
Jul 14, 2020
Merged

bootstrap: Improve wording on docs for verbose-tests #74334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions config.toml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,7 @@
# desired in distributions, for example.
#rpath = true

# Emits extraneous output from tests to ensure that failures of the test
# harness are debuggable just from logfiles.
# Emits extra output from tests so test failures are debuggable just from logfiles.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting myself from rust-lang/rustc-dev-guide#795 (comment):

This change doesn't seem right, specifically "test harness" refers to the code running the tests, rather than the tests themselves. And it is extraneous for the common case of e.g. libtest not crashing.

cc @Mark-Simulacrum

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verbose tests indeed changes nothing about tests, only the harnesses (compiletest and libtest) which invoke them.

#verbose-tests = false

# Flag indicating whether tests are compiled with optimizations (the -O flag).
Expand Down