Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #84620

Merged
merged 32 commits into from
Apr 27, 2021
Merged

Rollup of 5 pull requests #84620

merged 32 commits into from
Apr 27, 2021

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    afaefea View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Configuration menu
    Copy the full SHA
    b48699e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5625d58 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#7100 - ABouttefeux:unused_io_amount, r=camste…

    …ffen
    
    Unused io amount detects `.read().ok()?`
    
    fixes rust-lang#7096
    changelog: unused_io_amount now detect expertion like `.read().ok()?`,  `.read().or_else(|err| ...)?` and similar expressions.
    bors committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    0ab7acc View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#7120 - cherryblossom000:7106, r=Manishearth

    `single_component_path_imports`: ignore `pub(crate) use some_macro;`
    
    Fixes rust-lang#7106
    
    *Please write a short comment explaining your change (or "none" for internal only changes)*
    
    changelog: Ignore exporting a macro within a crate using `pub(crate) use some_macro;` for [`single_component_path_imports`]
    bors committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    74f5599 View commit details
    Browse the repository at this point in the history
  5. Fix lintcheck on windows

    Jarcho committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    6c42375 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Auto merge of rust-lang#7124 - Jarcho:lintcheck-windows, r=phansch

    Fix lintcheck on windows
    
    changelog: None
    bors committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    08e36d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Configuration menu
    Copy the full SHA
    36e9382 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. Configuration menu
    Copy the full SHA
    db7ad64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f5be5e View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#7129 - camsteffen:copied-msrv, r=Manishearth

    cloned_instead_of_copied MSRV
    
    changelog: none
    (since the lint is still new)
    
    Fixes rust-lang#7127
    
    r? `@Manishearth`
    bors committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    c4e2d36 View commit details
    Browse the repository at this point in the history
  4. Update backtrace to 0.3.57

    Adds support for symbol resolution on illumos systems.
    jclulow committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    d21fb2b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Configuration menu
    Copy the full SHA
    efc4c6c View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#7132 - rust-lang:single_element_loop_iter, r=…

    …Manishearth
    
    extend `single_element_loop` to match `.iter()`
    
    This extends `single_element_loop` to also match `[..].iter()` in the loop argument. Related to rust-lang#7125, but not completely fixing it due to the lint only firing if the array expression contains a local variable.
    
    ---
    
    changelog: none
    bors committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    1bb3b12 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dcf4e07 View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#7134 - camsteffen:copied-msrv, r=Manishearth

    Finish MSRV for cloned_instead_of_copied
    
    changelog: none
    
    r? `@Manishearth`
    bors committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    a362a4d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    84003aa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d7627dc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    33ed8b5 View commit details
    Browse the repository at this point in the history
  8. Refactor MSRV aliases

    camsteffen committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    340b570 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3a8e759 View commit details
    Browse the repository at this point in the history
  10. Auto merge of rust-lang#7137 - camsteffen:msrv-mod, r=llogiq

    Refactor MSRV aliases
    
    changelog: Remove MSRV from `needless_question_mark` and change MSRV for `missing_const_for_fn` from 1.37.0 to 1.46.0.
    
    First [mentioned on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Better.20MSRV.20testing.20idea/near/236215074).
    
    * Moves MSRV constants into `clippy_utils::msrvs`. Now they are named to represent a stabilized feature flag or library item that is required for a lint's suggestion.
    * `needless_question_mark` no longer has MSRV. Not needed since it does not suggest adding `?`.
    * `missing_const_for_fn` MSRV was changed from 1.37.0 to 1.46.0. This seems to be a past mistake.
    bors committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    f33d86d View commit details
    Browse the repository at this point in the history
  11. Auto merge of rust-lang#7136 - mgacek8:issue6965_manual_unwrap_or_inv…

    …alid_sugg_macro_expansion, r=llogiq
    
    manual_unwrap_or: fix invalid code suggestion, due to macro expansion
    
    fixes rust-lang#6965
    
    changelog: fix invalid code suggestion in `manual_unwrap_or` lint, due to macro expansion
    bors committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    0a330e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Configuration menu
    Copy the full SHA
    b3629d2 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#7138 - mgacek8:issue6808_iter_cloned_collect_…

    …FN_with_large_array, r=Manishearth
    
    Fix FN in `iter_cloned_collect` with a large array
    
    fixes rust-lang#6808
    changelog: Fix FN in `iter_cloned_collect` with a large array
    
    I spotted that [is_iterable_array](https://github.com/rust-lang/rust-clippy/blob/a362a4d1d0edb66aef186c1d27b28c60573078f4/clippy_lints/src/loops/explicit_iter_loop.rs#L67-L75) function that `explicit_iter_loop` lint is using only works for array sizes <= 32.
    There is this comment:
    > IntoIterator is currently only implemented for array sizes <= 32 in rustc
    
    I'm a bit confused, because I read that [IntoIterator for arrays](https://doc.rust-lang.org/src/core/array/mod.rs.html#194-201) with const generic `N` is stable since = "1.0.0". Although Const Generics MVP were stabilized in Rust 1.51.
    
    Should I set MSRV for the current change? I will try to test with older compilers soon.
    bors committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    9af07e6 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#7128 - Jarcho:const_fn_ice, r=flip1995

    Fix ICE checking for feature gated const fn
    
    fixes: rust-lang#7126
    changelog: Fix ICE in `missing_const_for_fn` when using a feature-gated `const fn`
    bors committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    7c7683c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d4af90e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#84132 - Manishearth:lldb-nonstandard, r=Mar…

    …k-Simulacrum
    
    Ignore nonstandard lldb version strings in compiletest
    
    Fixes rust-lang#84131
    
    Unsure if I should do the same for the Apple LLDB branch above.
    Dylan-DPC authored Apr 27, 2021
    Configuration menu
    Copy the full SHA
    78e0f2f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#84521 - CDirkx:hermit-dedup, r=Mark-Simulacrum

    Reuse modules on `hermit`
    
    Reuse the following modules on `hermit`:
    - `unix::path` (contents identical)
    - `unsupported::io` (contents identical)
    - `unsupported::thread_local_key` (contents functionally identical, only changes are the panic error messages)
    
    `@rustbot` label: +T-libs-impl
    Dylan-DPC authored Apr 27, 2021
    Configuration menu
    Copy the full SHA
    e7be5dd View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#84563 - jclulow:backtrace-upgrade, r=Mark-S…

    …imulacrum
    
    Update backtrace to 0.3.57
    
    Adds support for symbol resolution on illumos systems.
    Dylan-DPC authored Apr 27, 2021
    Configuration menu
    Copy the full SHA
    7969de2 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#84610 - flip1995:clippyup, r=Manishearth,fl…

    …ip1995
    
    Update Clippy
    
    Out of cycle sync: I want to get rust-lang/rust-clippy#7129 into beta that is branched next week.
    
    This sync only adds one new feature in efc4c6c, which looks fine to me. Otherwise it only contains bug fixes and/or restricts lints further.
    
    r? `@Manishearth`
    Dylan-DPC authored Apr 27, 2021
    Configuration menu
    Copy the full SHA
    38e0dbd View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#84613 - lcnr:recursive-types, r=jackh726

    move representability checks to rustc_ty_utils
    Dylan-DPC authored Apr 27, 2021
    Configuration menu
    Copy the full SHA
    24782c7 View commit details
    Browse the repository at this point in the history