Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 🎨 cleaner packet routing in gateway #2204

Merged
merged 26 commits into from
Oct 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3febb86
refactor: :art: cleaner packet routing in gateway
drazisil Oct 10, 2024
056487e
Merge remote-tracking branch 'origin/dev' into better-packets
drazisil Oct 10, 2024
8978456
fix(chat): fix error deserializing message in receiveChatData function
drazisil Oct 10, 2024
ff70b7d
feat(packets): add tests for GameMessageHeader serialization and dese…
drazisil Oct 10, 2024
53bf529
refactor(tests): remove redundant test case in socketUtility.test.ts
drazisil Oct 10, 2024
77d691a
refactor(types): remove duplicated toString and toHexString methods f…
drazisil Oct 10, 2024
e5f913b
refactor(packets): update ServerPacket constructor usage
drazisil Oct 10, 2024
5f61042
refactor(types): remove duplicated import in SerializedBuffer.ts
drazisil Oct 10, 2024
e36215c
refactor(portRouters): add logging to notFoundRouter
drazisil Oct 10, 2024
deea9b4
refactor(portRouters): add error logging for notFoundRouter
drazisil Oct 10, 2024
c38cc6f
refactor(mcotsPortRouter): replace console.log with log.debug for rou…
drazisil Oct 10, 2024
7792fb6
test: :bug: correct payload and header serialization and update tests
drazisil Oct 10, 2024
775370a
refactor(gateway): move tests to a seperate tsconfig file
drazisil Oct 11, 2024
2b04e31
refactor(tests): add ServerMessagePayload copy test
drazisil Oct 11, 2024
12e9715
refactor(tests): add GameMessagePayload copy test
drazisil Oct 11, 2024
dd26e11
refactor(gateway): update tsconfig include patterns
drazisil Oct 11, 2024
d03cda9
chore: update dependencies and add new packages
drazisil Oct 11, 2024
49b7514
refactor(gateway): add validation for port number in addPortRouter fu…
drazisil Oct 11, 2024
4def44f
refactor(tests): move socketErrorHandler.test.ts to the test directory
drazisil Oct 11, 2024
0ba96ae
fix(GamePacket): ensure sufficient data before deserialization
drazisil Oct 11, 2024
79c0ce2
test(mcotsPortRouter): add unit tests for error logging and data hand…
drazisil Oct 12, 2024
5e0d752
Merge remote-tracking branch 'origin/dev' into better-packets
drazisil Oct 12, 2024
3faae73
refactor(GamePacket): update return type in copy method
drazisil Oct 12, 2024
e7623e2
refactor(GamePacket): update error message in setDataBuffer method
drazisil Oct 12, 2024
4cc5a36
refactor(mcotsPortRouter): handle error when parsing initial message
drazisil Oct 12, 2024
49defc2
refactor(State): remove unused onDataHandlers property
drazisil Oct 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,6 @@ jobs:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
codecovcli --verbose do-upload --fail-on-error --flag persona --name persona --dir packages/persona
- name: Codecov upload sessions coverage
if: ${{ always() }} # using always() to always run this step because i am uploading test results and coverage in one step
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
codecovcli --verbose do-upload --fail-on-error --flag sessions --name sessions --dir packages/sessions
- name: Codecov upload shard coverage
if: ${{ always() }} # using always() to always run this step because i am uploading test results and coverage in one step
env:
Expand Down
4 changes: 3 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
name: rustyserver

services:
nginx:
build:
Expand Down Expand Up @@ -63,4 +65,4 @@ services:
# - db

volumes:
pgadmin:
pgadmin:
7 changes: 2 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,11 @@
"@sentry/profiling-node": "8.34.0",
"adminjs": "^7.8.13",
"fastify": "^5.0.0",
"lobby": "link:packages/lobby",
"moment": "^2.30.1",
"pino": "^9.4.0",
"pino-pretty": "^11.2.2",
"rusty-motors-chat": "link:src/chat",
"rusty-motors-cli": "link:packages/cli",
"rusty-motors-connection": "link:packages/connection",
"rusty-motors-database": "link:packages/database",
"rusty-motors-gateway": "link:packages/gateway",
"rusty-motors-lobby": "link:packages/lobby",
Expand All @@ -52,7 +50,6 @@
"rusty-motors-nps": "link:packages/nps",
"rusty-motors-patch": "link:packages/patch",
"rusty-motors-personas": "link:packages/persona",
"rusty-motors-sessions": "link:packages/sessions",
"rusty-motors-shard": "link:packages/shard",
"rusty-motors-shared": "link:packages/shared",
"rusty-motors-shared-packets": "link:packages/shared-packets",
Expand All @@ -72,7 +69,7 @@
"@tsconfig/node-lts": "^20.1.3",
"@tsconfig/node20": "^20.1.4",
"@types/chai": "5.0.0",
"@types/node": "^22.7.5",
"@types/node": "^20.16.11",
"@types/sinon": "17.0.3",
"@types/sinon-chai": "4.0.0",
"@typescript-eslint/eslint-plugin": "^8.8.1",
Expand Down Expand Up @@ -117,4 +114,4 @@
}
},
"packageManager": "pnpm@9.12.1+sha512.e5a7e52a4183a02d5931057f7a0dbff9d5e9ce3161e33fa68ae392125b79282a8a8a470a51dfc8a0ed86221442eb2fb57019b0990ed24fab519bf0e1bc5ccfc4"
}
}
335 changes: 0 additions & 335 deletions packages/core/src/serializationHelpers.test.ts

This file was deleted.

Loading
Loading