-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native-events mode #339
Conversation
As @pzuraq noticed in #ec-page-object slack channel we still allow to specify jquery selectors in page objects in a native-dom mode:
That means the current native-dom name is not very precise. We might get a naming collision If we occasionally will decide to provide true native-dom mode w/o jquery on board. So in the last commit I've renamed native-dom to native-events as @magistrula previously suggested. Also |
@ro0gr can you rebase with master? |
Sure. Will do it today |
It's finally green 🎉 |
👏 👏 👏 👏 🎉 🍾 |
@ro0gr Thanks a lot for working on this! Also to all others who helped to get this to land! (@pzuraq @magistrula @san650) This is highly appreciated! 👍 👏 I just wished I could have helped more, but time was too limited. But we do have an app I want to give the alpha version a try, will report back if there are any issues! |
addresses #311
I've rebased commits from #325 for more convenient review and addressed @pzuraq comment.
ember-native-events
context allows not to rely on global ember test helpers(click
,fillIn
,..).One of the benefits of native-events mode is an ability to test jquery-free applications.
However we still use jquery selectors like
:is
,:contains
etc(#289).In order to drop dependency on jquery provided by Ember by default we bundle our own jquery version.
To enable native dom helpers in your tests, put this lines into your
tests/test-helper.js
:Tests
I've expanded property tests with [native-dom] mode for both integration and acceptance contexts. It seems a little not optimal however it gives a solid code coverage with a minimal efforts.
todo