-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gitattributes #2188
Add .gitattributes #2188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. I think the crlf line ending should not be set for all .bat and .cmd files, but only for specific .bat and .cmd files that might present this issue in future such as RunReport.bat, build.bat, ParseVersion.bat, configure.bat and so on, if you can find other similarities. -> 8c1292f
2. I didn't check them all, but in case make sure to verify that all .bat and .cmd files are already in UTF-8.
https://stackoverflow.com/questions/11303405/force-encode-from-us-ascii-to-utf-8-iconv
|
I’ve changed my mind since then, so I just pushed 8827ece to reflect that. |
I checked them all again.
|
Co-authored-by: isaak654 <isaak654@users.noreply.github.com>
🤔 Both main.yml and lupdate.yml are failing with some of the changes (in my forked repo). |
It has only worked in a limited number of cases
Add .gitattributes to avoid Encoding and EOL formatting changes.