[GITHUB-35] Give bigger control over server.properties #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-oledzki
force-pushed
the
config-yml
branch
7 times, most recently
from
ef7a9de
to
d66767c
Compare
wojtek-oledzki
changed the title
lobsterdore
reviewed
Nov 6, 2018
| @@ -1,24 +1,17 @@ | |||
| ANSIBLE_INSTALL_VERSION ?= 2.5.9 | |||
| ANSIBLE_INSTALL_VERSION ?= 2.6.7 | |||
There was a problem hiding this comment.
Do we definitely need these changes to the Makefile? It's fine if so but we will need to push these updates to the other roles at some point.
There was a problem hiding this comment.
if the changes are ok, I will send PR to scaffold repo
lobsterdore
reviewed
Nov 6, 2018
wojtek-oledzki
force-pushed
the
config-yml
branch
2 times, most recently
from
2f2cc02
to
0c03e78
Compare
wojtek-oledzki
commented
Nov 6, 2018
It's now possible to specify any server property using `sansible_kafka_server_properties` dictionary. ``` sansible_kafka_server_properties: offsets.topic.replication.factor: 1 ``` This change also REMOVES: * a lot of previous defaults for `server.properties`. * AWS autodiscovery scripts fixes: #23 fixes: #29
wojtek-oledzki
force-pushed
the
config-yml
branch
from
0c03e78
to
edd8426
Compare
|
LGTM 👍 |
dennisconrad
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible to specify any server property using
sansible_kafka_server_propertiesdictionary.This change also REMOVES:
server.properties.fixes: #23
fixes: #29