-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GITHUB-35] Give bigger control over server.properties #34
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[GITHUB-35] Give bigger control over server.properties
It's now possible to specify any server property using `sansible_kafka_server_properties` dictionary. ``` sansible_kafka_server_properties: offsets.topic.replication.factor: 1 ``` This change also REMOVES: * a lot of previous defaults for `server.properties`. * AWS autodiscovery scripts fixes: #23 fixes: #29
- Loading branch information
commit edd8426761fc606a279e5bcc21efd557aeba3e03
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v2.0 | ||
v3.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,53 +1,26 @@ | ||
--- | ||
|
||
sansible_kafka_apache_mirror: https://archive.apache.org/dist/ | ||
sansible_kafka_auto_create_topics: "false" | ||
sansible_kafka_aws_cluster_assigned_id_enabled: no | ||
sansible_kafka_aws_cluster_assigned_id_tag_name: instanceindex | ||
# If enabled AWS will be used to figure out which host and id should be used | ||
# Note that you must install the AWS CLI tools to use this feature | ||
sansible_kafka_aws_cluster_autodiscover_enabled: no | ||
sansible_kafka_aws_cluster_autodiscover_hosts: [] | ||
sansible_kafka_aws_cluster_autodiscover_id_tag_name: KafkaID | ||
sansible_kafka_aws_cluster_autodiscover_lookup_filter: "Name=tag:Environment,Values=dev Name=tag:Role,Values=kafka" | ||
sansible_kafka_aws_cluster_autodiscover_r53_zone_id: ~ | ||
sansible_kafka_aws_delay: 5 | ||
sansible_kafka_aws_retries: 3 | ||
sansible_kafka_conf_dir: /home/kafka/etc | ||
sansible_kafka_controlled_shutdown_enable: true | ||
sansible_kafka_controlled_shutdown_max_retries: 3 | ||
sansible_kafka_controlled_shutdown_retry_backoff_ms: 2000 | ||
sansible_kafka_data_dir: /home/kafka/data | ||
sansible_kafka_default_replication_factor: 1 | ||
sansible_kafka_group: kafka | ||
sansible_kafka_heap_opts: "-Xmx{{ (ansible_memtotal_mb / 2) | int }}m -Xms{{ (ansible_memtotal_mb / 2) | int }}m" | ||
sansible_kafka_id: 1 | ||
sansible_kafka_interface_advertise: ~ | ||
sansible_kafka_interface_bind: ~ | ||
sansible_kafka_java_vendor: openjdk | ||
sansible_kafka_java_version: 8 | ||
sansible_kafka_jmx_port: 9999 | ||
sansible_kafka_log_cleanup_interval_mins: 1 | ||
sansible_kafka_log_dir: /home/kafka/log | ||
sansible_kafka_log_flush_interval_messages: 10000 | ||
sansible_kafka_log_flush_interval_ms: 1000 | ||
sansible_kafka_log_level: WARN | ||
sansible_kafka_log_retention_bytes: 104857600 # 100 M | ||
sansible_kafka_log_retention_hours: 24 | ||
sansible_kafka_log_segment_bytes: 104857600 | ||
sansible_kafka_max_open_files: 4098 | ||
sansible_kafka_num_io_threads: 2 | ||
sansible_kafka_num_network_threads: 2 | ||
sansible_kafka_num_partitions: 2 | ||
sansible_kafka_port: 9092 | ||
sansible_kafka_socket_receive_buffer_bytes: 1048576 | ||
sansible_kafka_socket_request_max_bytes: 104857600 | ||
sansible_kafka_socket_send_buffer_bytes: 1048576 | ||
sansible_kafka_server_properties: {} | ||
sansible_kafka_tarball_location: /home/kafka/tmp | ||
sansible_kafka_user: kafka | ||
sansible_kafka_version_kafka: 0.10.1.1 | ||
sansible_kafka_version_kafka: 2.0.0 | ||
sansible_kafka_version_scala: 2.11 | ||
sansible_kafka_wait_for_kafka_port: 120 | ||
sansible_kafka_zookeeper_connection_timeout_ms: 1000000 | ||
sansible_kafka_zookeeper_hosts: | ||
- localhost | ||
- localhost:2181 |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we definitely need these changes to the Makefile? It's fine if so but we will need to push these updates to the other roles at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the changes are ok, I will send PR to scaffold repo