Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal 0.35 compability #37

Closed
wants to merge 2 commits into from

Conversation

carlhoerberg
Copy link

No description provided.

@straight-shoota
Copy link
Collaborator

Just a heads up: The breaking change is probably going to be reverted in Crystal 0.35.1 (crystal-lang/crystal#9469), making the IO changes in this PR obsolete (and also #36).
The compress changes are still good, though.

@straight-shoota
Copy link
Collaborator

@carlhoerberg Would you mind removing the IO changes from this PR. They're no longer necessary (and indeed incompatible) with Crystal 0.35.1.

@carlhoerberg
Copy link
Author

updated

@straight-shoota
Copy link
Collaborator

Fixed in #38. Tt's basically the same change but also fixes return types on abstract method overrides (see #35). Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants