Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert message div blocked some menu bar dropdown buttons #4428

Closed
JinXJinX opened this issue Jan 24, 2019 · 8 comments · Fixed by #4916
Closed

Alert message div blocked some menu bar dropdown buttons #4428

JinXJinX opened this issue Jan 24, 2019 · 8 comments · Fixed by #4916

Comments

@JinXJinX
Copy link
Contributor

Expected Behavior

Alert message should not block partial menu bar dropdown buttons.

Actual Behavior

menu bar dropdown buttons are blocked by alert message div
scratch 3 0 gui

Steps to Reproduce

  1. trigger a alert message
  2. click 'file' button in menu bar
  3. you can see 'new' button and 'load from computer' button is covered by alert's div

Explain what someone needs to do in order to see what's described in Actual behavior above

Operating System and Browser

Mac OS 10.14.2 Safari 12.0.2/ Chrome 71.0.3578/ FireFox 64.0.2

@thisandagain
Copy link
Contributor

@carljbowman Any thoughts on the desired z-index here? I can see arguments both ways.

@carljbowman
Copy link
Contributor

Seeing this, I lean towards z-indexing the nav and nav menus above alerts. Since alerts sometimes prompt using the file menu: for example if you lose an internet connection we prompt you to download your project. We do provide a download button in this specific alert example, but I could see people attempting to use the File > Menu to try to reinitiate a save or download to computer.

It's also a bit awkward that alerts could potentially block "Undo" & "Redo" in the Edit menu.

All that said, I am open to other thoughts as to why we should keep the current z-indexing or alerts above nav and nav menus.

@thisandagain
Copy link
Contributor

Thanks @carljbowman. Sounds good.

@thisandagain
Copy link
Contributor

/cc @chrisgarrity Another z-index issue if you'd like to add this one to your backlog.

@benjiwheeler
Copy link
Contributor

Related to #4226

@benjiwheeler
Copy link
Contributor

From my checking, it appears this issue was already fixed before #4916 went in. Possibly it was fixed by #4452.

@apple502j
Copy link
Contributor

@benjiwheeler Not for me on Firefox 76:

  1. On sound tab, upload non-sounds (this creates an alert that cannot disappear)
  2. You cannot click Code/Costume tab
  3. On develop you can

@benjiwheeler
Copy link
Contributor

@apple502j I totally agree about the Code/Costume tabs. But this issue is about menu bar dropdown menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants