-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert message div blocked some menu bar dropdown buttons #4428
Comments
@carljbowman Any thoughts on the desired z-index here? I can see arguments both ways. |
Seeing this, I lean towards z-indexing the nav and nav menus above alerts. Since alerts sometimes prompt using the file menu: for example if you lose an internet connection we prompt you to download your project. We do provide a download button in this specific alert example, but I could see people attempting to use the File > Menu to try to reinitiate a save or download to computer. It's also a bit awkward that alerts could potentially block "Undo" & "Redo" in the Edit menu. All that said, I am open to other thoughts as to why we should keep the current z-indexing or alerts above nav and nav menus. |
Thanks @carljbowman. Sounds good. |
/cc @chrisgarrity Another z-index issue if you'd like to add this one to your backlog. |
fixes scratchfoundation/scratch-www#2587 and scratchfoundation#4428 changed menu-bar z-index to one more than monitors so drop down menus cover monitors when opened.
Related to #4226 |
@benjiwheeler Not for me on Firefox 76:
|
@apple502j I totally agree about the Code/Costume tabs. But this issue is about menu bar dropdown menus. |
Expected Behavior
Alert message should not block partial menu bar dropdown buttons.
Actual Behavior
menu bar dropdown buttons are blocked by alert message div
Steps to Reproduce
Explain what someone needs to do in order to see what's described in Actual behavior above
Operating System and Browser
Mac OS 10.14.2 Safari 12.0.2/ Chrome 71.0.3578/ FireFox 64.0.2
The text was updated successfully, but these errors were encountered: