Ignore pointer-events in alert container CSS #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM! We'll need to test it across various devices, but I think it shouldn't be problematic. Thanks for this, and sorry it took us so long to review it. |
benjiwheeler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #4428
Proposed Changes
Add pointer-events to alert container CSS
Reason for Changes
Container caught the onclick event and didn't pass to things under it, therefore it blocked menu items.
Test Coverage
To test this, go to Sound tab, upload a non-music file (such as text), and cause forever Importing. (this bug is documented #4639 )
Try changing tabs, selecting menu items, and else. All should work fine.
This is one of my progress for adding "Record Project Video".