Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add eslint comments #6356

Merged
merged 2 commits into from
May 11, 2021
Merged

add eslint comments #6356

merged 2 commits into from
May 11, 2021

Conversation

benjiwheeler
Copy link
Contributor

Adds some eslint comments to make gui ready to pass eslint linting if eslint version is updated.

@benjiwheeler benjiwheeler added this to the November 2020 milestone Nov 9, 2020
@benjiwheeler benjiwheeler self-assigned this Nov 10, 2020
@benjiwheeler
Copy link
Contributor Author

I'm not positive this is the right approach -- it might be better to try to resolve these violations by fixing them more substantially

@benjiwheeler
Copy link
Contributor Author

Looks good to @seotts and me!

@benjiwheeler benjiwheeler merged commit 308fa3c into scratchfoundation:develop May 11, 2021
@benjiwheeler benjiwheeler deleted the eslint-prepare branch May 11, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benjiwheeler benjiwheeler

Labels
pr - needs review
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.
1 participant
@benjiwheeler