Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add eslint comments #6356

Merged
merged 2 commits into from
May 11, 2021
Merged

add eslint comments #6356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f32c7
add eslint comments
benjiwheeler Nov 9, 2020
a36af11
added proptypes for asset
benjiwheeler May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/target-pane/target-pane.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ const TargetPane = ({

const spriteShape = PropTypes.shape({
costume: PropTypes.shape({
// asset is defined in scratch-storage's Asset.js
asset: PropTypes.object, // eslint-disable-line react/forbid-prop-types
url: PropTypes.string,
name: PropTypes.string.isRequired,
// The following are optional because costumes uploaded from disk
Expand All @@ -112,6 +114,7 @@ const spriteShape = PropTypes.shape({
rotationCenterX: PropTypes.number,
rotationCenterY: PropTypes.number
}),
costumeCount: PropTypes.number,
direction: PropTypes.number,
id: PropTypes.string,
name: PropTypes.string,
Expand Down
4 changes: 2 additions & 2 deletions src/containers/monitor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,8 @@ Monitor.propTypes = {
min: PropTypes.number,
mode: PropTypes.oneOf(['default', 'slider', 'large', 'list']),
monitorLayout: PropTypes.shape({
monitors: PropTypes.object,
savedMonitorPositions: PropTypes.object
monitors: PropTypes.object, // eslint-disable-line react/forbid-prop-types
savedMonitorPositions: PropTypes.object // eslint-disable-line react/forbid-prop-types
}).isRequired,
onDragEnd: PropTypes.func.isRequired,
opcode: PropTypes.string.isRequired, // eslint-disable-line react/no-unused-prop-types
Expand Down