-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(2911): Adding schema for Job Template Pipeline Report #527
Conversation
.prettierrc.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to check this in? can you add this file to the .gitignore
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is useful because the style rules that screwdriver adheres to are different from the prettier defaults. This means that anyone who has format-on-write set up is going to fail lint by default. But if it's not appropriate to keep, I can remove it.
I just copied the same prettier config from the main repo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of copying the file to each module repo, can we centralize and share the configuration?
https://prettier.io/docs/en/configuration.html#sharing-configurations
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs rebase to catch up with the master
branch
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
🎉 This PR is included in version 22.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
See screwdriver-cd/screwdriver#2911
Objective
Adds schema for the pipelineUsage endpoint response.
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.