Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2911): Adding schema for Job Template Pipeline Report #527

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

nathom
Copy link
Contributor

@nathom nathom commented Aug 21, 2023

Context

See screwdriver-cd/screwdriver#2911

Objective

Adds schema for the pipelineUsage endpoint response.

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

api/pipelineUsage.js Outdated Show resolved Hide resolved
api/pipelineUsage.js Outdated Show resolved Hide resolved
.prettierrc.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to check this in? can you add this file to the .gitignore file

Copy link
Contributor Author

@nathom nathom Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useful because the style rules that screwdriver adheres to are different from the prettier defaults. This means that anyone who has format-on-write set up is going to fail lint by default. But if it's not appropriate to keep, I can remove it.

I just copied the same prettier config from the main repo here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of copying the file to each module repo, can we centralize and share the configuration?
https://prettier.io/docs/en/configuration.html#sharing-configurations

nathom and others added 4 commits August 23, 2023 16:59
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Copy link
Member

@sagar1312 sagar1312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs rebase to catch up with the master branch

test/api/pipelineUsage.test.js Outdated Show resolved Hide resolved
test/api/pipelineUsage.test.js Outdated Show resolved Hide resolved
test/api/pipelineUsage.test.js Show resolved Hide resolved
@sagar1312 sagar1312 changed the title Job Template Pipeline Usage feat(2911): Adding schema for Job Template Pipeline Report Aug 28, 2023
@sagar1312 sagar1312 merged commit 40c9b60 into screwdriver-cd:master Aug 28, 2023
@sd-buildbot
Copy link

🎉 This PR is included in version 22.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants