Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ulterior fixes from #1636 #1638

Merged
merged 3 commits into from
Nov 23, 2023
Merged

fix: ulterior fixes from #1636 #1638

merged 3 commits into from
Nov 23, 2023

Conversation

Constrat
Copy link
Contributor

Ulterior fixes related to #1636 brought up for 15 inches models.

@seerge
Copy link
Owner

seerge commented Nov 23, 2023

@Constrat hm this pr conflicts with last one you did :)

@Constrat
Copy link
Contributor Author

Constrat commented Nov 23, 2023

Yeah, it was pretty much expected, as I change some small things. (GitHub doesn't like them :P)
I'll tweak something else, then resolve the conflicts :)

@seerge seerge merged commit 93d639f into seerge:main Nov 23, 2023
0 of 2 checks passed
@Constrat
Copy link
Contributor Author

Ops, I still had a commit to push with a little style and LIDL from zone 0 to zone 2 as it makes more sense looking at this:
G533_US_1100

@Constrat
Copy link
Contributor Author

If you want to, just replace this:

g-helper/app/USB/Aura.cs

Lines 402 to 406 in 93d639f

0, 0, 0, 0, 1, 1, 2, 2, 2, 2, 2, 3, 3, 3, 3,
/* LB1 LB1 LB3 LB4 LB5 LB6 */
5, 5, 4, 6, 7, 7,
/* KSTN LOGO LIDL LIDR */
3, 0, 0, 3,

With this:

             0,    0,    0,    0,                1,                1,    2,    2,          2,    2,    2,    3,          3,    3,    3,
        /* LB1   LB1   LB3                                                                                             LB4   LB5   LB6   */
             5,    5,    4,                                                                                              6,    7,    7,
        /* KSTN  LOGO  LIDL  LIDR  */
             3,    0,    2,    3,

@Constrat
Copy link
Contributor Author

Constrat commented Nov 23, 2023

Wait how did a = go in the code?. It's Github conflict thingy.
@seerge I think it might be better to revert

seerge added a commit that referenced this pull request Nov 23, 2023
@seerge
Copy link
Owner

seerge commented Nov 23, 2023

@Constrat I have already merged + just pushed tweaks over that (i rearranged zones back for models w/o numpad)

@Kowken can you check if this build looks ok for you ?
GHelper.zip

@Kowken
Copy link

Kowken commented Nov 23, 2023

@Constrat I have already merged + just pushed tweaks over that (i rearranged zones back for models w/o numpad)

@Kowken can you check if this build looks ok for you ?

GHelper.zip

Looks fine to meimage

@seerge
Copy link
Owner

seerge commented Nov 23, 2023

@Kowken bingo.

I assume my latest "tweaks" don't break backlight on the numpad version of keyboard @Constrat ?

If so - thank you both

@Constrat
Copy link
Contributor Author

Constrat commented Nov 23, 2023

@Kowken bingo.

I assume my latest "tweaks" don't break backlight on the numpad version of keyboard @Constrat ?

If so - thank you both

Yep, just checked, everything working as expected, the zones are 5-width in my case. Maybe the regex for the model should be any 17 inch? Instead of just G713R? (If the asus nomeclature stays the same, usually 17 inches have numpads)

The only "issue" left is the zone 6 that seems bigger than all the others even if the algorithm seems symmetrical to the zone 4
More than an issue it's a bother xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants