-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ulterior fixes from #1636 #1638
Conversation
@Constrat hm this pr conflicts with last one you did :) |
Yeah, it was pretty much expected, as I change some small things. (GitHub doesn't like them :P) |
If you want to, just replace this: Lines 402 to 406 in 93d639f
With this: 0, 0, 0, 0, 1, 1, 2, 2, 2, 2, 2, 3, 3, 3, 3,
/* LB1 LB1 LB3 LB4 LB5 LB6 */
5, 5, 4, 6, 7, 7,
/* KSTN LOGO LIDL LIDR */
3, 0, 2, 3,
|
|
@Constrat I have already merged + just pushed tweaks over that (i rearranged zones back for models w/o numpad) @Kowken can you check if this build looks ok for you ? |
Yep, just checked, everything working as expected, the zones are 5-width in my case. Maybe the regex for the model should be any 17 inch? Instead of just G713R? (If the asus nomeclature stays the same, usually 17 inches have numpads) The only "issue" left is the zone 6 that seems bigger than all the others even if the algorithm seems symmetrical to the zone 4 |
Ulterior fixes related to #1636 brought up for 15 inches models.