fix: Add optional language tag for Lift export #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should it say "if orthographic unchecked"?
…On Wed, Mar 2, 2022, 3:08 PM Darcy Wong ***@***.***> wrote:
follow-on to #65 <#65>
Since the "Ethnologue ID" is currently used for SFM Export, this adds an
"optional language tag" to use in Lift exports when "Orthographic" is
blank. This new text field is free-text (not limited to 3 characters as
Ethnologue ID is), so the user/student will need to be guided on a proper
BCP 47 tag to use.
To recap, the project language of the Lift export will use (in order of
what's defined)
1. Orthographic
2. Optional language tag
3. und for undefined
Screenshot of the updated
[image: new export]
<https://user-images.githubusercontent.com/7358010/156320744-53027f7c-09c6-4aec-b34e-4b5647cb275b.png>
dialog
------------------------------
You can view, comment on, or merge this pull request online at:
#68
Commit Summary
- bfabdf9
<bfabdf9>
fix: Add optional language tag for Lift export
File Changes
(6 files <https://github.com/sillsdev/SpeechAnalyzer/pull/68/files>)
- *M* Src/Lang/SA_DEU.rc
<https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-a6a68cc41d51366667fd473e5e0ee01e81efb6dfb6f626260f7e8a759574280f>
(8)
- *M* Src/Lang/SA_ENU.rc
<https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-e64e53d72452136b23d8bf78690c7a4b3250047f02e2fbe164ad2ecf1999fdcf>
(14)
- *M* Src/Lang/sa_lang_resource.h
<https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-221522ae66bff247f4d7ca864aced11ef29ab0dd1320cf15d45aa19235be67b6>
(2)
- *M* Src/SA/DlgExportLift.cpp
<https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-57e09934789751c9aa286a3b948be2202c7eff0797bfbe825dcaee7069797b66>
(1)
- *M* Src/SA/ExportLiftSettings.h
<https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-70546e0f1c6608af947607a64a2c2968f2b80d6ea5c2b17e4d90f9a1713dec06>
(1)
- *M* Src/SA/Sa_Doc.cpp
<https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-d3a0ddb4ab3b88ed98028004bdc621bac3c1afdbf4c38cb765454b14d7713d5d>
(6)
Patch Links:
- https://github.com/sillsdev/SpeechAnalyzer/pull/68.patch
- https://github.com/sillsdev/SpeechAnalyzer/pull/68.diff
—
Reply to this email directly, view it on GitHub
<#68>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2I6KLJ4CIG7FRR5R4OUS3U54OZJANCNFSM5PWTYTBA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-on to #65
Since the "Ethnologue ID" is currently used for SFM Export, this adds an "optional language tag" to use in Lift exports when "Orthographic" is blank. This new text field is free-text (not limited to 3 characters as Ethnologue ID is), so the user/student will need to be guided on a proper BCP 47 tag to use.
To recap, the project language of the Lift export will use (in order of what's defined)
undfor undefinedScreenshot of the updated dialog
