Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting a goal in Data Cleanup sometimes navigates to the wrong goal #698

Closed
imnasnainaec opened this issue Sep 8, 2020 · 2 comments · Fixed by #925
Closed

Selecting a goal in Data Cleanup sometimes navigates to the wrong goal #698

imnasnainaec opened this issue Sep 8, 2020 · 2 comments · Fixed by #925
Assignees
@imnasnainaec
Labels
bug Something isn't working frontend goal

Comments

@imnasnainaec
Copy link
Collaborator

Our goal routing is fragile, and this seems to be an issue with caching and/or use of refreshing a goal page or using forward/back buttons from within a goal.
@imnasnainaec imnasnainaec added bug Something isn't working frontend labels Sep 8, 2020
@imnasnainaec
Copy link
Collaborator Author

This is probably covered by #456

@imnasnainaec imnasnainaec self-assigned this Jan 14, 2021
@imnasnainaec
Copy link
Collaborator Author

Probably related to #243, #588, #795.

This was referenced Jan 14, 2021
Closed
Merged
imnasnainaec added a commit that referenced this issue Jan 21, 2021
@imnasnainaec
Goal loading cleanup; Fix goal history reversal bug. (#925)
7e6c4ad 
Cleanup and refactor: 
* Move currentUser check to within userEditFetch. 
* Remove unused GoalSelectorScroll. 
* Remove useless goal update in CharacterInventoryActions. 
* Replace custom functions getIndexInHistory and findGoalByName with use of .find(). 
* Make consistent usage of async/await with goal actions. 
Bug-fix: Remove .reverse() on the goal history in the state, and only reverse what is given to the history display. Resolves issues #243, #698, #795.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imnasnainaec imnasnainaec

Labels
bug Something isn't working frontend goal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Goal loading cleanup sillsdev/TheCombine
1 participant
@imnasnainaec