Goal loading cleanup

[imnasnainaec]

Cleanup and refactor:

• Remove unused GoalSelectorScroll.
• Remove useless goal update in CharacterInventoryActions.
• Replace custom functions getIndexInHistory and findGoalByName with use of .find().
• Make consistent usage of async/await with goal actions.

Bug-fix: Remove .reverse() on the goal history in the state, and only reverse what is given to the history display.

• Resolves Empty steps in mergedups #243
• Resolves Selecting a goal in Data Cleanup sometimes navigates to the wrong goal #698
• Resolves Merge Duplicates requires 2 clicks to load #795

There's still some funny business with loading MergeDups (e.g. #588), so additional work is needed on general loading and advancing of multi-step goals.

This change is 

[codecov-io]

Codecov Report

Merging #925 (57c5849) into master (7f06e93) will decrease coverage by 0.57%.
The diff coverage is 74.41%.

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
- Coverage   50.40%   49.83%   -0.58%     
==========================================
  Files         238      234       -4     
  Lines        6660     6508     -152     
  Branches      425      406      -19     
==========================================
- Hits         3357     3243     -114     
+ Misses       2985     2961      -24     
+ Partials      318      304      -14     

Flag	Coverage Δ
backend	55.47% <ø> (ø)
frontend	43.83% <74.41%> (-1.44%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/App/DefaultState.tsx	100.00% <ø> (ø)
...ojectScreen/CreateProject/CreateProjectActions.tsx	39.39% <0.00%> (ø)
src/rootReducer.tsx	100.00% <ø> (ø)
src/types/goals.tsx	100.00% <ø> (ø)
src/components/GoalTimeline/GoalsActions.tsx	77.61% <76.92%> (-0.17%)	⬇️
.../components/GoalTimeline/GoalTimelineComponent.tsx	68.96% <100.00%> (+0.21%)	⬆️
...harInventoryCreation/CharacterInventoryActions.tsx	17.64% <100.00%> (-7.36%)	⬇️
src/components/ContextMenu/ContextMenu.tsx	90.00% <0.00%> (+5.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f06e93...57c5849. Read the comment docs.

[jasonleenaylor]

Reviewed 17 of 19 files at r1, 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)