Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console error during npm run test-frontend -- VernDialog #976

Closed
imnasnainaec opened this issue Feb 3, 2021 · 2 comments · Fixed by #2245
Closed

Console error during npm run test-frontend -- VernDialog #976

imnasnainaec opened this issue Feb 3, 2021 · 2 comments · Fixed by #2245
Labels
component: DataEntry test

Comments

@imnasnainaec
Copy link
Collaborator

imnasnainaec commented Feb 3, 2021 •
edited
Loading

npm run test-frontend -- VernDialog triggers three instances of:

    console.error
      Material-UI: Unable to set focus to a ListItem whose component has not been rendered.

      at node_modules/@material-ui/core/ListItem/ListItem.js:168:17
      at commitHookEffectListMount (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10345:26)
      at commitLifeCycles (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10401:9)
      at commitLayoutEffects (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:13295:7)
      at HTMLUnknownElement.callCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9972:14)
      at HTMLUnknownElement.callTheUserObjectsOperation (node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
      at innerInvokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:318:25)
      at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
@johnthagen
Copy link
Collaborator

Subtask of #1119

@johnthagen johnthagen mentioned this issue Apr 23, 2021
Closed
@imnasnainaec
Copy link
Collaborator Author

Once this is done, set up jest to fail if any console errors are thrown.

@imnasnainaec imnasnainaec mentioned this issue Apr 25, 2023
Closed
4 tasks
@imnasnainaec imnasnainaec mentioned this issue Jun 12, 2023
Merged
imnasnainaec added a commit that referenced this issue Jun 15, 2023
@imnasnainaec
Implement Grammatical Category / Part of Speech (#2245)
5830cff 
Add grammatical category to backend model;
Only enable grammatical category in projects that import senses with grammatical info;
Display grammatical category in frontend as "Part of speech":
* DataEntry: another column in SenseDialog and VernDialog;
* MergeDups: a small colored icon in a sense's upper-left corner;
* ReviewEntries: a new column between glosses and semantic domains
(Resolves #976, #2274, and the first part of #604)
@imnasnainaec imnasnainaec mentioned this issue Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: DataEntry test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Grammatical Category / Part of Speech sillsdev/TheCombine
2 participants
@imnasnainaec @johnthagen