Implement Grammatical Category / Part of Speech #2245
Conversation
imnasnainaec
added
enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
===========================================
- Coverage 58.85% 45.41% -13.44%
===========================================
Files 236 196 -40
Lines 7779 3928 -3851
Branches 502 510 +8
===========================================
- Hits 4578 1784 -2794
+ Misses 2830 1772 -1058
- Partials 371 372 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 15 of 29 files at r1, 52 of 75 files at r2, all commit messages.
Reviewable status: 67 of 95 files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/Buttons/PartOfSpeechButton.tsx line 38 at r2 (raw file):
<IconButtonWithTooltip buttonId={props.buttonId} icon={<Square fontSize="small" sx={{ color }} />}
What about Hexagon? Circle was too easily confused with record, but Square also looks like Stop when playing.
There was a problem hiding this comment.
Reviewed 5 of 29 files at r1, 23 of 75 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/SenseCell.tsx line 15 at r2 (raw file):
export default function SenseCell( props: SenseCellProps & FieldParameterStandard
🤦
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status:
Add grammatical category to backend model;
Only enable grammatical category in projects that import senses with grammatical info;
Display grammatical category in frontend as "Part of speech":
Resolves the first part of #604
Also, fixes #976, fixes #2274
This change is