-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get semantic domain tree to switch languages #2043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2043 +/- ##
==========================================
+ Coverage 48.56% 48.88% +0.31%
==========================================
Files 298 298
Lines 9434 9432 -2
Branches 681 678 -3
==========================================
+ Hits 4582 4611 +29
+ Misses 4295 4271 -24
+ Partials 557 550 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/TreeView/TreeViewComponent.tsx
line 52 at r2 (raw file):
dispatch(updateTreeLanguage(newLang)); } dispatch(initTreeDomain(newLang)).catch(console.error);
If this catch is simply dumping the error to the console how is it superior to not catching it?
Code quote:
.catch(console.error);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)
src/components/TreeView/TreeViewComponent.tsx
line 52 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
If this catch is simply dumping the error to the console how is it superior to not catching it?
Got it cleared up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #1555
This change is