Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get semantic domain tree to switch languages #2043

Merged
merged 8 commits into from
Apr 25, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 14, 2023

Resolves #1555


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Apr 14, 2023
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.31 🎉

Comparison is base (fc3490c) 48.56% compared to head (f886b18) 48.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2043      +/-   ##
==========================================
+ Coverage   48.56%   48.88%   +0.31%     
==========================================
  Files         298      298              
  Lines        9434     9432       -2     
  Branches      681      678       -3     
==========================================
+ Hits         4582     4611      +29     
+ Misses       4295     4271      -24     
+ Partials      557      550       -7     
Flag Coverage Δ
backend 72.27% <ø> (+0.07%) ⬆️
frontend 32.17% <66.66%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/types/writingSystem.ts 100.00% <ø> (ø)
src/components/TreeView/TreeViewActions.ts 64.70% <66.66%> (+12.07%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/TreeView/TreeViewComponent.tsx line 52 at r2 (raw file):

      dispatch(updateTreeLanguage(newLang));
    }
    dispatch(initTreeDomain(newLang)).catch(console.error);

If this catch is simply dumping the error to the console how is it superior to not catching it?

Code quote:

.catch(console.error);

@imnasnainaec imnasnainaec marked this pull request as draft April 17, 2023 21:26
@imnasnainaec imnasnainaec marked this pull request as ready for review April 18, 2023 18:18
Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)


src/components/TreeView/TreeViewComponent.tsx line 52 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

If this catch is simply dumping the error to the console how is it superior to not catching it?

Got it cleared up.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit be31a20 into master Apr 25, 2023
@imnasnainaec imnasnainaec deleted the sem-dom-lang branch April 25, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic Domain Language Change doesn't update in the TreeView
3 participants